Update Android to R21e #109355

cyyever · 2023-09-15T03:21:35Z

R19c is too old, R21e is LTS version.

pytorch-bot · 2023-09-15T03:21:38Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109355

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7482951 with merge base 9455af5 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

cyyever · 2023-10-09T03:36:54Z

@pytorchbot rebase

pytorchmergebot · 2023-10-09T03:38:58Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2023-10-09T03:39:04Z

Successfully rebased update_android onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout update_android && git pull --rebase)

malfet

Please don't change the download URL (uploading NDK to our mirror)

.ci/docker/common/install_android.sh

malfet

LGTM if CI is green. Thank you for the updates.
[Edit] Will debug what is going on with the downloads

huydhn

IIRC, I encounter an build issue with Vulkan when trying this locally. Let's see if this pass CI

cyyever · 2023-10-11T00:28:09Z

Thank you

huydhn · 2023-10-11T00:38:26Z

Btw, you might also want to rebase this to include #110976. I just land this to add a new release workflow for Android.

cyyever · 2023-10-11T00:39:42Z

@huydhn wait some hours until it goes into viable/strict

cyyever · 2023-10-11T04:56:33Z

@pytorchbot rebase

pytorchmergebot · 2023-10-11T04:58:37Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2023-10-11T04:58:43Z

Successfully rebased update_android onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout update_android && git pull --rebase)

cyyever · 2023-10-18T23:29:48Z

@pytorchbot rebase

pytorchmergebot · 2023-10-18T23:31:57Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2023-10-18T23:32:02Z

Successfully rebased update_android onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout update_android && git pull --rebase)

cyyever · 2023-10-21T15:15:26Z

@pytorchbot rebase

pytorchmergebot · 2023-10-21T15:17:33Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2023-10-21T15:17:39Z

Successfully rebased update_android onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout update_android && git pull --rebase)

cyyever · 2023-10-22T16:31:28Z

@huydhn I have no permission to docker push, help me verify the PR?

huydhn · 2023-10-25T18:32:58Z

@huydhn I have no permission to docker push, help me verify the PR?

Sorry, I missed your message. I will need to prepare the ECR entry for the new docker images as the names are different. After that, rerunning the job will work

cyyever · 2023-10-29T01:42:24Z

@huydhn CI is green. Is it time to merge?

huydhn · 2023-10-30T06:47:11Z

@pytorchbot merge

pytorchmergebot · 2023-10-30T06:49:01Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

cyyever · 2023-10-30T13:14:16Z

@huydhn Now there is an error

ANDROID_HOME not a directory; did you install it under /opt/android/sdk?

huydhn · 2023-10-30T20:58:28Z

Hmm, I don't see any issue in trunk. Is that failing locally for you? The SDK should be under that path https://github.com/pytorch/pytorch/blob/main/.ci/docker/common/install_android.sh#L51

R19c is too old, R21e is LTS version. Pull Request resolved: pytorch#109355 Approved by: https://github.com/malfet, https://github.com/huydhn

cyyever requested a review from jeffdaily as a code owner September 15, 2023 03:21

pytorch-bot bot added the topic: not user facing topic category label Sep 15, 2023

cyyever marked this pull request as draft September 15, 2023 03:21

pytorchbot added the open source label Sep 15, 2023

cyyever force-pushed the update_android branch from 4f85e93 to a232e1a Compare September 15, 2023 03:34

cyyever marked this pull request as ready for review October 9, 2023 03:36

cyyever requested a review from a team as a code owner October 9, 2023 03:36

pytorchmergebot force-pushed the update_android branch from a232e1a to 872dbe7 Compare October 9, 2023 03:39

cyyever force-pushed the update_android branch 2 times, most recently from 60a0b9d to 9209079 Compare October 9, 2023 03:43

mikaylagawarecki requested a review from malfet October 9, 2023 22:10

mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 9, 2023

malfet requested changes Oct 9, 2023

View reviewed changes

.ci/docker/common/install_android.sh Outdated Show resolved Hide resolved

cyyever changed the title ~~Update android to 21e~~ Update Android to 21e Oct 10, 2023

malfet approved these changes Oct 10, 2023

View reviewed changes

huydhn approved these changes Oct 10, 2023

View reviewed changes

huydhn added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 10, 2023

cyyever changed the title ~~Update Android to 21e~~ Update Android to R21e Oct 11, 2023

pytorchmergebot force-pushed the update_android branch from 4c0750a to 750e73a Compare October 11, 2023 04:58

pytorchmergebot force-pushed the update_android branch from 750e73a to 1fbde9e Compare October 18, 2023 23:32

cyyever force-pushed the update_android branch from 1fbde9e to 4412dd7 Compare October 19, 2023 00:09

cyyever added 2 commits October 21, 2023 15:17

Update android to 21e

4f5899c

Change download URL

7482951

pytorchmergebot force-pushed the update_android branch from 4412dd7 to 7482951 Compare October 21, 2023 15:17

huydhn added ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR test-config/default labels Oct 25, 2023

pytorchmergebot added the merging label Oct 30, 2023

pytorchmergebot added the Merged label Oct 30, 2023

pytorchmergebot removed the merging label Oct 30, 2023

pytorchmergebot closed this in 0d669f0 Oct 30, 2023

huydhn mentioned this pull request Oct 31, 2023

[CI] android CI is flakey #112497

Closed

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023

Update Android to R21e (pytorch#109355)

cf56584

R19c is too old, R21e is LTS version. Pull Request resolved: pytorch#109355 Approved by: https://github.com/malfet, https://github.com/huydhn

Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023

Update Android to R21e (pytorch#109355)

f9619d5

R19c is too old, R21e is LTS version. Pull Request resolved: pytorch#109355 Approved by: https://github.com/malfet, https://github.com/huydhn

cyyever deleted the update_android branch January 31, 2024 00:38

Uh oh!

Update Android to R21e #109355

Update Android to R21e #109355

Uh oh!

Conversation

cyyever commented Sep 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109355

✅ No Failures

Uh oh!

cyyever commented Oct 9, 2023

Uh oh!

pytorchmergebot commented Oct 9, 2023

Uh oh!

pytorchmergebot commented Oct 9, 2023

Uh oh!

malfet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

malfet left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huydhn left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cyyever commented Oct 11, 2023

Uh oh!

huydhn commented Oct 11, 2023

Uh oh!

cyyever commented Oct 11, 2023

Uh oh!

cyyever commented Oct 11, 2023

Uh oh!

pytorchmergebot commented Oct 11, 2023

Uh oh!

pytorchmergebot commented Oct 11, 2023

Uh oh!

cyyever commented Oct 18, 2023

Uh oh!

pytorchmergebot commented Oct 18, 2023

Uh oh!

pytorchmergebot commented Oct 18, 2023

Uh oh!

cyyever commented Oct 21, 2023

Uh oh!

pytorchmergebot commented Oct 21, 2023

Uh oh!

pytorchmergebot commented Oct 21, 2023

Uh oh!

cyyever commented Oct 22, 2023

Uh oh!

huydhn commented Oct 25, 2023

Uh oh!

cyyever commented Oct 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

huydhn commented Oct 30, 2023

Uh oh!

pytorchmergebot commented Oct 30, 2023

Merge started

Uh oh!

cyyever commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

huydhn commented Oct 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

cyyever commented Sep 15, 2023 •

edited

Loading

pytorch-bot bot commented Sep 15, 2023 •

edited

Loading

malfet left a comment •

edited

Loading

huydhn left a comment •

edited

Loading

cyyever commented Oct 29, 2023 •

edited

Loading

cyyever commented Oct 30, 2023 •

edited

Loading