Skip to content

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Sep 17, 2023

Following the recent works, it is necessary to add CUDA files in the docker container so that we can lint CUDA code in the future.

cc @ezyang @Skylion007 @malfet

@cyyever cyyever requested a review from jeffdaily as a code owner September 17, 2023 11:22
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 17, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 17, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109456

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit e7e53f9 with merge base d860313 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever marked this pull request as draft September 17, 2023 14:23
@cyyever cyyever force-pushed the cuda_lint branch 2 times, most recently from 0e910fa to d9dc63f Compare September 17, 2023 14:54
@cyyever cyyever changed the title Use CUDA builds for lintrunner Build CUDA image for lintrunner Sep 17, 2023
@cyyever cyyever marked this pull request as ready for review September 17, 2023 15:16
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (especially as this is a no op at the moment), but please revert progress bar change or explain why it is needed)

@cyyever cyyever requested a review from a team as a code owner September 17, 2023 15:33
@cyyever
Copy link
Collaborator Author

cyyever commented Sep 17, 2023

Of course I have no permission to push

@ezyang
Copy link
Contributor

ezyang commented Sep 18, 2023

@pytorchbot merge -f "yolo docker image update"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants