[3/N] Add -Wdeprecated and related fixes #109698

cyyever · 2023-09-20T07:15:50Z

This PR follows #108626. Hopefully we can enable the warning in the next PR.
cc @EikanWang @jgong5 @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @ezyang @Skylion007

pytorch-bot · 2023-09-20T07:15:52Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109698

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit f44426e with merge base 428cbd7 ():

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

trunk / linux-focal-rocm5.6-py3.8 / test (default, 2, 3, linux.rocm.gpu, unstable) (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Skylion007

Minor changes / questions

torch/csrc/api/include/torch/nn/cloneable.h

torch/csrc/utils/invalid_arguments.cpp

torch/csrc/api/src/nn/modules/activation.cpp

aten/src/ATen/native/vulkan/ops/VulkanPackedContext.h

ezyang · 2023-09-20T17:53:06Z

not looking at this until the first two PRs successfully land and stick

cyyever · 2023-09-20T18:09:37Z

not looking at this until the first two PRs successfully land and stick

A strange IOS failure, no clue.

torch/csrc/distributed/rpc/rref_proto.cpp

Skylion007

LGTM

Skylion007

Actually, after reading the other comments I agree with @ezyang, let's wait a bit to make sure the other PRs stuck then merge this in.

ezyang · 2023-09-21T18:20:05Z

@cyyever are you on slack? I think we may need some messaging for the other two PRs

cyyever · 2023-10-01T17:19:43Z

Unrelated failures.

cyyever · 2023-10-01T23:54:50Z

@pytorchbot rebase

pytorchmergebot · 2023-10-01T23:57:12Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2023-10-01T23:57:17Z

Successfully rebased wdeprecated3 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout wdeprecated3 && git pull --rebase)

cyyever · 2023-10-02T23:52:11Z

@pytorchbot rebase

pytorchmergebot · 2023-10-02T23:54:16Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2023-10-02T23:54:23Z

Successfully rebased wdeprecated3 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout wdeprecated3 && git pull --rebase)

cyyever · 2023-10-03T12:52:56Z

@pytorchbot rebase

pytorchmergebot · 2023-10-03T12:55:05Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2023-10-03T12:55:11Z

Successfully rebased wdeprecated3 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout wdeprecated3 && git pull --rebase)

cyyever · 2023-10-03T22:48:17Z

@pytorchmergebot merge

pytorchmergebot · 2023-10-03T22:50:26Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorch-bot · 2023-10-04T14:29:21Z

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -m/--message

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

pytorch-bot · 2023-10-04T14:30:03Z

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -m/--message

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst}

Try @pytorchbot --help for more info.

PaliC · 2023-10-04T14:31:29Z

@pytorchbot revert -m "breaking quantization tests ( quantization/test_quantize_per_channel_sub_byte and quantization/test_quantize_per_channel_float_qparams) internally" -c ghfirst

It's unclear if the tests are also run externally/ why we don't see a similar breakage here. Regardless, here are the logs, hopefully they are helpful.

test_quantize_per_channel_sub_byte

/data/sandcastle/boxes/eden-trunk-hg-fbcode-fbsource/buck-out/v2/gen/fbcode/cd507d1e23f571ca/caffe2/test/quantization/__test_quantization__/test_quantization#link-tree/torch/_utils_internal.py:225: NCCL_DEBUG env var is set to None
/data/sandcastle/boxes/eden-trunk-hg-fbcode-fbsource/buck-out/v2/gen/fbcode/cd507d1e23f571ca/caffe2/test/quantization/__test_quantization__/test_quantization#link-tree/torch/_utils_internal.py:243: NCCL_DEBUG is forced to WARN from None
/data/sandcastle/boxes/eden-trunk-hg-fbcode-fbsource/buck-out/v2/gen/fbcode/cd507d1e23f571ca/caffe2/test/quantization/__test_quantization__/test_quantization#link-tree/torch/_utils_internal.py:157: [redacted warning that shouldn't be relevant to you]
test_quantize_per_channel_float_qparams (caffe2.test.quantization.core.test_quantized_tensor.TestQuantizedTensor) ... fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/string_view:233: std::basic_string_view::const_reference std::basic_string_view<char>::operator[](std::basic_string_view::size_type) const [_CharT = char, _Traits = std::char_traits<char>]: Assertion '__pos < this->_M_len' failed.

Test was never completed. The test process might have crashed.

test_quantize_per_channel_float_qparams

/data/sandcastle/boxes/eden-trunk-hg-fbcode-fbsource/buck-out/v2/gen/fbcode/cd507d1e23f571ca/caffe2/test/quantization/__test_quantization__/test_quantization#link-tree/torch/_utils_internal.py:225: NCCL_DEBUG env var is set to None
/data/sandcastle/boxes/eden-trunk-hg-fbcode-fbsource/buck-out/v2/gen/fbcode/cd507d1e23f571ca/caffe2/test/quantization/__test_quantization__/test_quantization#link-tree/torch/_utils_internal.py:243: NCCL_DEBUG is forced to WARN from None
/data/sandcastle/boxes/eden-trunk-hg-fbcode-fbsource/buck-out/v2/gen/fbcode/cd507d1e23f571ca/caffe2/test/quantization/__test_quantization__/test_quantization#link-tree/torch/_utils_internal.py:157: [redacted warning that shouldn't be relevant to you]
test_quantize_per_channel_float_qparams (caffe2.test.quantization.core.test_quantized_tensor.TestQuantizedTensor) ... fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/string_view:233: std::basic_string_view::const_reference std::basic_string_view<char>::operator[](std::basic_string_view::size_type) const [_CharT = char, _Traits = std::char_traits<char>]: Assertion '__pos < this->_M_len' failed.

Test was never completed. The test process might have crashed.

pytorchmergebot · 2023-10-04T14:33:36Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2023-10-04T14:33:51Z

@cyyever your PR has been successfully reverted.

This reverts commit c31fcda. Reverted #109698 on behalf of https://github.com/PaliC due to breaking quantization tests ( quantization/test_quantize_per_channel_sub_byte and quantization/test_quantize_per_channel_float_qparams) internally ([comment](#109698 (comment)))

cyyever requested review from H-Huang, aaronenyeshi, awgu, d4l3k, fduwjj, fegin, kiukchung, kwen2501, mrshenli, rohan-varma, wanchaol, wz337 and zhaojuanmao as code owners September 20, 2023 07:15

pytorch-bot bot added the release notes: vulkan release notes category label Sep 20, 2023

github-actions bot added the NNC label Sep 20, 2023

pytorchbot added the open source label Sep 20, 2023

cyyever force-pushed the wdeprecated3 branch 3 times, most recently from 9b389d9 to 01224f5 Compare September 20, 2023 09:20

Skylion007 reviewed Sep 20, 2023

View reviewed changes

cyyever requested a review from Skylion007 September 20, 2023 14:13

ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 21, 2023

Skylion007 reviewed Sep 21, 2023

View reviewed changes

torch/csrc/distributed/rpc/rref_proto.cpp Outdated Show resolved Hide resolved

Skylion007 approved these changes Sep 21, 2023

View reviewed changes

Skylion007 requested changes Sep 21, 2023

View reviewed changes

Skylion007 self-requested a review September 21, 2023 13:38

pytorchmergebot removed the merging label Oct 1, 2023

pytorchmergebot force-pushed the wdeprecated3 branch from 2af1afe to 5310dde Compare October 1, 2023 23:57

pytorchmergebot force-pushed the wdeprecated3 branch from 5310dde to 3e70b01 Compare October 2, 2023 23:54

Fix Wdeprecated warnings

f44426e

pytorchmergebot force-pushed the wdeprecated3 branch from 3e70b01 to f44426e Compare October 3, 2023 12:55

pytorchmergebot added the merging label Oct 3, 2023

pytorchmergebot added Merged and removed merging labels Oct 3, 2023

pytorchmergebot closed this in c31fcda Oct 3, 2023

cyyever deleted the wdeprecated3 branch October 3, 2023 23:50

pytorchmergebot added the Reverted label Oct 4, 2023

[3/N] Add -Wdeprecated and related fixes #109698

[3/N] Add -Wdeprecated and related fixes #109698

Uh oh!

Conversation

cyyever commented Sep 20, 2023 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109698

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

Skylion007 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ezyang commented Sep 20, 2023

Uh oh!

cyyever commented Sep 20, 2023

Uh oh!

Uh oh!

Skylion007 left a comment

Choose a reason for hiding this comment

Uh oh!

Skylion007 left a comment

Choose a reason for hiding this comment

Uh oh!

ezyang commented Sep 21, 2023

Uh oh!

cyyever commented Oct 1, 2023

Uh oh!

cyyever commented Oct 1, 2023

Uh oh!

pytorchmergebot commented Oct 1, 2023

Uh oh!

pytorchmergebot commented Oct 1, 2023

Uh oh!

cyyever commented Oct 2, 2023

Uh oh!

pytorchmergebot commented Oct 2, 2023

Uh oh!

pytorchmergebot commented Oct 2, 2023

Uh oh!

cyyever commented Oct 3, 2023

Uh oh!

pytorchmergebot commented Oct 3, 2023

Uh oh!

pytorchmergebot commented Oct 3, 2023

Uh oh!

cyyever commented Oct 3, 2023

Uh oh!

pytorchmergebot commented Oct 3, 2023

Merge started

Uh oh!

pytorch-bot bot commented Oct 4, 2023

Uh oh!

pytorch-bot bot commented Oct 4, 2023

Uh oh!

PaliC commented Oct 4, 2023

Uh oh!

pytorchmergebot commented Oct 4, 2023

Uh oh!

pytorchmergebot commented Oct 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cyyever commented Sep 20, 2023 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Sep 20, 2023 •

edited

Loading