Skip to content

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Oct 9, 2023

It is time to clang-tidy aten.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 9, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110861

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9330ade with merge base db76052 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever marked this pull request as draft October 9, 2023 12:47
@cyyever cyyever force-pushed the clang_tidy_coverage22 branch 5 times, most recently from 83b6113 to 718572e Compare October 10, 2023 00:39
@cyyever cyyever changed the title Use clang-tidy in aten/src/ATen/core Apply clang-tidy to aten/src/ATen/core/ Oct 10, 2023
@cyyever cyyever force-pushed the clang_tidy_coverage22 branch from 718572e to 9330ade Compare October 10, 2023 01:07
@cyyever cyyever changed the title Apply clang-tidy to aten/src/ATen/core/ [1/N] Apply clang-tidy to aten/src/ATen/core/ Oct 10, 2023
@cyyever
Copy link
Collaborator Author

cyyever commented Oct 10, 2023

@pytorchbot label ciflow/binaries

@pytorch-bot pytorch-bot bot added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Oct 10, 2023
@cyyever
Copy link
Collaborator Author

cyyever commented Oct 10, 2023

@pytorchbot label ciflow/trunk

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 10, 2023
@cyyever cyyever marked this pull request as ready for review October 10, 2023 07:05
@cyyever
Copy link
Collaborator Author

cyyever commented Oct 10, 2023

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 10, 2023
@Skylion007
Copy link
Collaborator

Not ready to enable the clang-tidy lintrunner on it yet?

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 10, 2023

Not ready to enable the clang-tidy lintrunner on it yet?

May be in the next PR

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 10, 2023

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants