Skip to content

[caffe2] avoid variable shadowing #111476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[caffe2] avoid variable shadowing #111476

wants to merge 1 commit into from

Conversation

h-friederich
Copy link
Contributor

Summary:
Some builds use -Wshadow and currently there is a compiler warning when building that file.

Code inspection shows that torch::autograd::impl::get_view_autograd_meta simply extracts information from the passed object, which is const. Therefore the returned views should be the same all the time, and we can fetch the view only once.

Test Plan:
CI

NOTE: please advise for a more comprehensive test plan.

Differential Revision: D50407625

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111476

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fc391d9 with merge base fb88760 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 18, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: h-friederich / name: Hannes Friederich (fc391d9)

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50407625

@github-actions
Copy link
Contributor

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50407625

@h-friederich @facebook-github-bot
[caffe2] avoid variable shadowing (pytorch#111476)
fc391d9 
Summary:

Some builds use -Wshadow and currently there is a compiler warning when building that file.

Code inspection shows that `torch::autograd::impl::get_view_autograd_meta` simply extracts information from the passed object, which is `const`. Therefore the returned views should be the same all the time, and we can fetch the view only once.

topic: not user facing

Test Plan: CI

Reviewed By: albanD

Differential Revision: D50407625
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50407625

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 23, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@h-friederich @xuhancn
[caffe2] avoid variable shadowing (pytorch#111476)
9193d1a 
Summary:
Some builds use -Wshadow and currently there is a compiler warning when building that file.

Code inspection shows that `torch::autograd::impl::get_view_autograd_meta` simply extracts information from the passed object, which is `const`. Therefore the returned views should be the same all the time, and we can fetch the view only once.

Test Plan:
CI

NOTE: please advise for a more comprehensive test plan.

Differential Revision: D50407625

Pull Request resolved: pytorch#111476
Approved by: https://github.com/Skylion007, https://github.com/albanD
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@h-friederich @Skylion007
[caffe2] avoid variable shadowing (pytorch#111476)
59eba9e 
Summary:
Some builds use -Wshadow and currently there is a compiler warning when building that file.

Code inspection shows that `torch::autograd::impl::get_view_autograd_meta` simply extracts information from the passed object, which is `const`. Therefore the returned views should be the same all the time, and we can fetch the view only once.

Test Plan:
CI

NOTE: please advise for a more comprehensive test plan.

Differential Revision: D50407625

Pull Request resolved: pytorch#111476
Approved by: https://github.com/Skylion007, https://github.com/albanD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@albanD albanD albanD approved these changes

@soulitzer soulitzer Awaiting requested review from soulitzer soulitzer is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@h-friederich @facebook-github-bot @pytorchmergebot @Skylion007 @albanD