[re-land][inductor] Refactor and optimize allocation calls (#111117) #111511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int3
requested review from
H-Huang,
awgu,
fduwjj,
fegin,
kwen2501,
mrshenli,
rohan-varma,
wanchaol,
wz337 and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111511
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit aa12f2e with merge base 74f6f7a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
int3
force-pushed
the
export-D50429424
branch
from
dca732d to
951f2dc
Compare
int3
force-pushed
the
export-D50429424
branch
from
951f2dc to
cf3c82b
Compare
…11117) Summary: This is a re-land of pytorch#111117 with updates to our internal tests included. This splits out changes from pytorch#102625 to make things easier to review. This diff creates a `make_allocation()` method that extracts the logic from `make_buffer_allocation()` while allowing us to allocate non-buffer objects. In particular, we will use this to allocate memory pools during memory planning. This diff also includes a small optimization -- if the desired allocation is contiguous, then we emit a call to `empty()` instead of `empty_strided()` with its superfluous stride argument. Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/9ce0ae836d6801a39776897b9e891cd978b28aea Differential Revision: D50429424 fbshipit-source-id: ce5f02240574db6dbbac2dd45a90cf01ac76a3a1
Closed
|
This pull request was exported from Phabricator. Differential Revision: D50429424 |
int3
force-pushed
the
export-D50429424
branch
from
cf3c82b to
aa12f2e
Compare
jansel
approved these changes
Oct 23, 2023
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
…11117) (pytorch#111511) Summary: This is a re-land of pytorch#111117 with updates to our internal tests included. This splits out changes from pytorch#102625 to make things easier to review. This diff creates a `make_allocation()` method that extracts the logic from `make_buffer_allocation()` while allowing us to allocate non-buffer objects. In particular, we will use this to allocate memory pools during memory planning. This diff also includes a small optimization -- if the desired allocation is contiguous, then we emit a call to `empty()` instead of `empty_strided()` with its superfluous stride argument. Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/9ce0ae836d6801a39776897b9e891cd978b28aea Differential Revision: D50429424 Pull Request resolved: pytorch#111511 Approved by: https://github.com/jansel
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…11117) (pytorch#111511) Summary: This is a re-land of pytorch#111117 with updates to our internal tests included. This splits out changes from pytorch#102625 to make things easier to review. This diff creates a `make_allocation()` method that extracts the logic from `make_buffer_allocation()` while allowing us to allocate non-buffer objects. In particular, we will use this to allocate memory pools during memory planning. This diff also includes a small optimization -- if the desired allocation is contiguous, then we emit a call to `empty()` instead of `empty_strided()` with its superfluous stride argument. Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/9ce0ae836d6801a39776897b9e891cd978b28aea Differential Revision: D50429424 Pull Request resolved: pytorch#111511 Approved by: https://github.com/jansel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a re-land of #111117 with
updates to our internal tests included.
This splits out changes from
#102625 to make things easier to
review.
This diff creates a
make_allocation()method that extracts the logicfrom
make_buffer_allocation()while allowing us to allocate non-bufferobjects. In particular, we will use this to allocate memory pools during
memory planning.
This diff also includes a small optimization -- if the desired
allocation is contiguous, then we emit a call to
empty()instead ofempty_strided()with its superfluous stride argument.Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/9ce0ae836d6801a39776897b9e891cd978b28aea
Differential Revision: D50429424
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler