Skip to content

[DCP][Test] Add use_dtensor subtests for test_state_dict FSDP test #111615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DCP][Test] Add use_dtensor subtests for test_state_dict FSDP test #111615

wants to merge 1 commit into from

Conversation

wz337
Copy link
Contributor

@wz337 wz337 commented Oct 19, 2023

As title.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 19, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 19, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111615

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c6370fa with merge base 0617f7f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@wz337 wz337 marked this pull request as ready for review October 19, 2023 22:56
@wz337 wz337 changed the title [DCP] Add use_dtensor subtests for test_state_dict FSDP test [DCP][Test] Add use_dtensor subtests for test_state_dict FSDP test Oct 19, 2023
fegin
fegin approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@fegin fegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wz337
Copy link
Contributor Author

wz337 commented Oct 20, 2023

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 20, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@wz337 @xuhancn
[DCP][Test] Add use_dtensor subtests for test_state_dict FSDP test (p…
f961c34 
…ytorch#111615)

As title.
Pull Request resolved: pytorch#111615
Approved by: https://github.com/fegin
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@wz337 @Skylion007
[DCP][Test] Add use_dtensor subtests for test_state_dict FSDP test (p…
6411ae2 
…ytorch#111615)

As title.
Pull Request resolved: pytorch#111615
Approved by: https://github.com/fegin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fegin fegin fegin approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wanchaol wanchaol Awaiting requested review from wanchaol

@fduwjj fduwjj Awaiting requested review from fduwjj

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wz337 @pytorchmergebot @fegin