Expose filename for tensor/storages created with from_file and document torch.from_file
#111688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111688
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ac0464a with merge base 2452e65 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…docs" [ghstack-poisoned]
…docs" [ghstack-poisoned]
mikaylagawarecki
added
topic: docs
…docs" Fixes #37439 cc albanD [ghstack-poisoned]
albanD
reviewed
Oct 24, 2023
albanD
approved these changes
Oct 24, 2023
…docs" Fixes #37439 cc albanD [ghstack-poisoned]
…docs" Fixes #37439 Also threads through filename so it is accessible via `t.storage().filename()` cc albanD [ghstack-poisoned]
…docs" Fixes #37439 Also threads through filename so it is accessible via `t.storage().filename()` cc albanD [ghstack-poisoned]
…docs" Fixes #37439 Also threads through filename so it is accessible via `t.storage().filename` cc albanD [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
mikaylagawarecki
changed the title
from_file and document torch.from_file
mikaylagawarecki
changed the title
from_file and document torch.from_filefrom_file and document torch.from_file
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 1, 2023
Pull Request resolved: #111856 Approved by: https://github.com/albanD ghstack dependencies: #111688
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
…ch#111688) Fixes pytorch#37439 Also threads through filename so it is accessible via `t.storage().filename` Pull Request resolved: pytorch#111688 Approved by: https://github.com/albanD
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
Pull Request resolved: pytorch#111856 Approved by: https://github.com/albanD ghstack dependencies: pytorch#111688
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…ch#111688) Fixes pytorch#37439 Also threads through filename so it is accessible via `t.storage().filename` Pull Request resolved: pytorch#111688 Approved by: https://github.com/albanD
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
Pull Request resolved: pytorch#111856 Approved by: https://github.com/albanD ghstack dependencies: pytorch#111688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37439
Also threads through filename so it is accessible via
t.storage().filenameStack from ghstack (oldest at bottom):
from_fileand document torch.from_file #111688cc @albanD