[fx] Add a faster method for inserting positional argument. #111974
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111974
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 307b644 with merge base b54ab57 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D50574435 |
zhxchen17
force-pushed
the
export-D50574435
branch
from
e26e348 to
cab2e31
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50574435 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D50574435 |
zhxchen17
force-pushed
the
export-D50574435
branch
2 times, most recently
from
eef0ecc to
c38742b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50574435 |
zhxchen17
force-pushed
the
export-D50574435
branch
from
c38742b to
d59bc2e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50574435 |
zhxchen17
force-pushed
the
export-D50574435
branch
from
d59bc2e to
85ca98f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50574435 |
…111974) Summary: Traditionally when user want to update the arguments for an FX node, the only way is to call the setter of .args property on nodes. This may be problematic when we insert a lot of arguments. Because of the semantics of the setter method, it has a worst case O(n) complexity. Adding a new insert_arg provides us two benefits: 1. The operation is guaranteed to be O(1) cost. 2. User can express the intentation more directly, instead of writing code like `node.args = (arg,) + node.args` Test Plan: caffe2/test:fx -- -r test_insert_arg Reviewed By: suo Differential Revision: D50574435
zhxchen17
force-pushed
the
export-D50574435
branch
from
85ca98f to
307b644
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50574435 |
angelayi
approved these changes
Oct 25, 2023
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
…111974) Summary: Traditionally when user want to update the arguments for an FX node, the only way is to call the setter of .args property on nodes. This may be problematic when we insert a lot of arguments. Because of the semantics of the setter method, it has a worst case O(n) complexity. Adding a new insert_arg provides us two benefits: 1. The operation is guaranteed to be O(1) cost. 2. User can express the intentation more directly, instead of writing code like `node.args = (arg,) + node.args` Test Plan: caffe2/test:fx -- -r test_insert_arg Reviewed By: suo Differential Revision: D50574435 Pull Request resolved: pytorch#111974 Approved by: https://github.com/angelayi
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
…111974) Summary: Traditionally when user want to update the arguments for an FX node, the only way is to call the setter of .args property on nodes. This may be problematic when we insert a lot of arguments. Because of the semantics of the setter method, it has a worst case O(n) complexity. Adding a new insert_arg provides us two benefits: 1. The operation is guaranteed to be O(1) cost. 2. User can express the intentation more directly, instead of writing code like `node.args = (arg,) + node.args` Test Plan: caffe2/test:fx -- -r test_insert_arg Reviewed By: suo Differential Revision: D50574435 Pull Request resolved: pytorch#111974 Approved by: https://github.com/angelayi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Traditionally when user want to update the arguments for an FX node, the only way is to call the setter of .args property on nodes. This may be problematic when we insert a lot of arguments. Because of the semantics of the setter method, it has a worst case O(n) complexity.
Adding a new insert_arg provides us two benefits:
node.args = (arg,) + node.argsTest Plan: caffe2/test:fx -- -r test_insert_arg
Reviewed By: suo
Differential Revision: D50574435