Skip to content

Conversation

@chenyang78
Copy link
Contributor

@chenyang78 chenyang78 commented Oct 26, 2023

Summary: otherwise, we would break internal uses

Differential Revision: D50681467
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 26, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112125

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 268b3db with merge base 89bd175 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50681467

@chenyang78 chenyang78 added topic: not user facing topic category and removed topic: not user facing topic category labels Oct 26, 2023
@swolchok
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 26, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@izaitsevfb
Copy link
Contributor

@pytorchbot revert -m "Trying to unblock the revert of #108690, please rebase and reland." -c ghfirst

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

Can't revert PR that was landed via phabricator as D50681467. Please revert by going to the internal diff and clicking Unland.

@izaitsevfb
Copy link
Contributor

@pytorchbot revert -m "Trying to unblock the revert of #108690, please rebase and reland." -c ghfirst

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

Can't revert PR that was landed via phabricator as D50681467. Please revert by going to the internal diff and clicking Unland.

izaitsevfb added a commit that referenced this pull request Oct 27, 2023
@izaitsevfb
Copy link
Contributor

@pytorchbot revert -m "Trying to unblock the revert of #108690, please rebase and reland." -c ghfirst

Last try, otherwise here's the manual revert: #112227

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

Can't revert PR that was landed via phabricator as D50681467. Please revert by going to the internal diff and clicking Unland.

@izaitsevfb
Copy link
Contributor

Giving up on reverting this, will reland it internally instead, which also fixes #108690.

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
Summary: otherwise, we would break internal uses

Differential Revision: D50681467

Pull Request resolved: pytorch#112125
Approved by: https://github.com/swolchok, https://github.com/desertfire, https://github.com/SherlockNoMad
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
Summary: otherwise, we would break internal uses

Differential Revision: D50681467

Pull Request resolved: pytorch#112125
Approved by: https://github.com/swolchok, https://github.com/desertfire, https://github.com/SherlockNoMad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants