Skip to content

Make numpy/lib vendored tests dynamo traceable #112147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Make numpy/lib vendored tests dynamo traceable #112147

wants to merge 12 commits into from

Conversation

ev-br
Copy link
Collaborator

@ev-br ev-br commented Oct 26, 2023 •
edited by pytorch-bot bot
Loading

@ev-br ev-br added module: numpy Related to numpy support, and also numpy compatibility of our operators topic: not user facing topic category module: dynamo keep-going Don't stop on first failure, keep running tests until the end ciflow/slow labels Oct 26, 2023
@ev-br ev-br requested a review from lezcano October 26, 2023 10:31
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 26, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112147

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 27fb536 with merge base 1c89ea7 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ev-br ev-br changed the title Tests under dynamo b4 Make numpy/lib vendored tests dynamo traceable Oct 26, 2023
@ev-br ev-br mentioned this pull request Oct 26, 2023
Closed
@lezcano
Copy link
Collaborator

lezcano commented Oct 26, 2023

@pytorchbot merge -r

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 26, 2023
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #112147, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: pull / linux-focal-py3.8-clang10 / test (dynamo, 1, 2, linux.2xlarge)

Details for Dev Infra team Raised by workflow job

pytorchmergebot pushed a commit that referenced this pull request Oct 26, 2023
@ev-br @pytorchmergebot
TST: make torch_np added tests dynamo traceable (#112149)
ed2cc4d 
Follow up #112146,  #112141 and #112147: make torch_np added tests dynamo traceable

Pull Request resolved: #112149
Approved by: https://github.com/lezcano
@ev-br
Copy link
Collaborator Author

ev-br commented Oct 26, 2023

@pytorchbot merge -i "ignore unrelated CI failures"

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 26, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: ignore unrelated CI failures

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@ev-br
Copy link
Collaborator Author

ev-br commented Oct 26, 2023

@pytorchbot merge -i

@ev-br
Copy link
Collaborator Author

ev-br commented Oct 27, 2023

@huydhn sorry for the churn this PR causes. Could you help me find out what are the numpy versions in the failing jobs please?

@lezcano
Copy link
Collaborator

lezcano commented Oct 27, 2023

@albanD do we have a minimum NumPy version we require? requirements.txt does not have one, which makes this a bit more difficult than needed.

@huydhn
Copy link
Contributor

huydhn commented Oct 27, 2023 •
edited
Loading

From what I see, the failed job is using numpy==1.21.2 coming from here https://github.com/pytorch/pytorch/blob/main/.ci/docker/common/install_conda.sh#L55-L59

CI-wise, it's ok to upgrade numpy version there I think.

@ev-br
Copy link
Collaborator Author

ev-br commented Oct 27, 2023

Thank you @huydhn !
Let me separate the concerns: hammer this PR into shape to pass with this numpy version, and bump the numpy version separately. Speaking of which, what would be the target version?

@huydhn
Copy link
Contributor

huydhn commented Oct 27, 2023 •
edited
Loading

Thank you @huydhn ! Let me separate the concerns: hammer this PR into shape to pass with this numpy version, and bump the numpy version separately. Speaking of which, what would be the target version?

Sounds good! If possible, I would prefer numpy==1.23.5 to match with that we have for 3.11 https://github.com/pytorch/pytorch/blob/main/.ci/docker/common/install_conda.sh#L55-L59. I also don't see any failures from that version, so I think it's working

@lezcano
Copy link
Collaborator

lezcano commented Oct 27, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ev-br added a commit to ev-br/pytorch that referenced this pull request Oct 29, 2023
@ev-br
CI: bump numpy version on CI
a398210 
As suggested by Huy Do over at
pytorch#112147 (comment)
@ev-br ev-br mentioned this pull request Oct 29, 2023
Closed
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@ev-br @xuhancn
TST: make torch_np added tests dynamo traceable (pytorch#112149)
c840fab 
Follow up pytorch#112146,  pytorch#112141 and pytorch#112147: make torch_np added tests dynamo traceable

Pull Request resolved: pytorch#112149
Approved by: https://github.com/lezcano
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@ev-br @xuhancn
Make numpy/lib vendored tests dynamo traceable (pytorch#112147)
91cd80b 
Follow up pytorch#112146 and  pytorch#112141 : make numpy/lib vendored tests dynamo traceable

Pull Request resolved: pytorch#112147
Approved by: https://github.com/lezcano
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@pytorchmergebot @xuhancn
Revert "Make numpy/lib vendored tests dynamo traceable (pytorch#112147)"
cdd1d78 
This reverts commit 190b6e4.

Reverted pytorch#112147 on behalf of https://github.com/huydhn due to Sorry for reverting this again, but this is failing in trunk https://hud.pytorch.org/pytorch/pytorch/commit/190b6e4ba88f6cf00d0bd08d6212a3fe6bb76eaa ([comment](pytorch#112147 (comment)))
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@ev-br @xuhancn
Make numpy/lib vendored tests dynamo traceable (pytorch#112147)
884800f 
Follow up pytorch#112146 and  pytorch#112141 : make numpy/lib vendored tests dynamo traceable

Pull Request resolved: pytorch#112147
Approved by: https://github.com/lezcano
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@ev-br @Skylion007
TST: make torch_np added tests dynamo traceable (pytorch#112149)
31abf3c 
Follow up pytorch#112146,  pytorch#112141 and pytorch#112147: make torch_np added tests dynamo traceable

Pull Request resolved: pytorch#112149
Approved by: https://github.com/lezcano
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@ev-br @Skylion007
Make numpy/lib vendored tests dynamo traceable (pytorch#112147)
520b22b 
Follow up pytorch#112146 and  pytorch#112141 : make numpy/lib vendored tests dynamo traceable

Pull Request resolved: pytorch#112147
Approved by: https://github.com/lezcano
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@pytorchmergebot @Skylion007
Revert "Make numpy/lib vendored tests dynamo traceable (pytorch#112147)"
c0fac69 
This reverts commit 190b6e4.

Reverted pytorch#112147 on behalf of https://github.com/huydhn due to Sorry for reverting this again, but this is failing in trunk https://hud.pytorch.org/pytorch/pytorch/commit/190b6e4ba88f6cf00d0bd08d6212a3fe6bb76eaa ([comment](pytorch#112147 (comment)))
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@ev-br @Skylion007
Make numpy/lib vendored tests dynamo traceable (pytorch#112147)
107a7b5 
Follow up pytorch#112146 and  pytorch#112141 : make numpy/lib vendored tests dynamo traceable

Pull Request resolved: pytorch#112147
Approved by: https://github.com/lezcano
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lezcano lezcano lezcano approved these changes

Assignees

No one assigned

Labels

ciflow/slow ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: numpy Related to numpy support, and also numpy compatibility of our operators open source Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ev-br @lezcano @pytorchmergebot @huydhn @pytorchbot