Remove passing disable_fastpath in kwargs

[isuruf]

Fixes an issue that came up in #112030

cc @mruberry @ZainRizvi

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112250

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit dee8896 with merge base 28ebe5d ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[isuruf]

@pytorchbot label "module: tests"

[lezcano]

Suggested change

	def __init__(self, *args, **kwargs):
	self.disable_fastpath = kwargs.pop("disable_fastpath", None)
	super().__init__(*args, **kwargs)
	self.ref_args = self.args
	def __init__(self, *args, **kwargs, disable_fastpath=None):
	super().__init__(*args, **kwargs)
	self.disable_fastpath = disable_fastpath

[lezcano]

Youc ould even assert not kwargs.

[lezcano]

Now that we are cleaning things, could you remove this ref_args, and instead use self.args from the parent class?

[isuruf]

It's still used at https://github.com/pytorch/pytorch/blob/7df675743c5196c5f1c5f8c1b8e2b000c0992a9b/torch/testing/_internal/common_methods_invocations.py#L8763-L8766

[lezcano]

Now all this is not necessary, right?

[isuruf]

It is still necessary because of "values" kwarg which I still don't understand how it's used. I want to clean that up in a separate PR, but I don't understand its usage.

[lezcano]

It'd be very nice if we could remove the values kwarg and the ref_args altogether in a follow-up PR

[lezcano]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here