Set default for IS_FBCODE flag #112766
Closed
Set default for IS_FBCODE flag #112766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: If IS_FBCODE is False, then we print an OSS repro if a test fails. We do set IS_FBCODE manually on most internal tests, but we don't do it for all of them. This PR changes it so that the IS_FBCODE gets set to the correct default value (and then tests are able to override them if they'd like). Test Plan: - Tested locally [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112766
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7dc54e5 with merge base 51a3838 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zou3519
added a commit
that referenced
this pull request
Nov 2, 2023
Summary: If IS_FBCODE is False, then we print an OSS repro if a test fails. We do set IS_FBCODE manually on most internal tests, but we don't do it for all of them. This PR changes it so that the IS_FBCODE gets set to the correct default value (and then tests are able to override them if they'd like). Test Plan: - Tested locally ghstack-source-id: 9f9368d Pull Request resolved: #112766
williamwen42
approved these changes
Nov 2, 2023
zou3519
added
ciflow/trunk
|
@pytorchbot merge -f "skipping CI; this only affects internal configs" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
Summary: If IS_FBCODE is False, then we print an OSS repro if a test fails. We do set IS_FBCODE manually on most internal tests, but we don't do it for all of them. This PR changes it so that the IS_FBCODE gets set to the correct default value (and then tests are able to override them if they'd like). Test Plan: - Tested locally Pull Request resolved: pytorch#112766 Approved by: https://github.com/williamwen42
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
Summary: If IS_FBCODE is False, then we print an OSS repro if a test fails. We do set IS_FBCODE manually on most internal tests, but we don't do it for all of them. This PR changes it so that the IS_FBCODE gets set to the correct default value (and then tests are able to override them if they'd like). Test Plan: - Tested locally Pull Request resolved: pytorch#112766 Approved by: https://github.com/williamwen42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
If IS_FBCODE is False, then we print an OSS repro if a test fails. We do
set IS_FBCODE manually on most internal tests, but we don't do it for
all of them. This PR changes it so that the IS_FBCODE gets set to the
correct default value (and then tests are able to override them if
they'd like).
Test Plan: