Remove torch distributed from CODEOWNERS #112813
Conversation
After adding support for labeler, we don't need CODEOWNERS. This change will cause the distributed team members previously listed in CODEOWNERS to stop being auto-added as reviewers on PRs touching these files. The preceding PR adds labeler support for these same sets of files, and contains instructions for adding yourself to be cc'd for that label. It is preferable to be auto-cc'd rather than auto-tagged as reviewer, so that there is more signal in the reviewers list (either someone opted in which shows the PR author someone is likely looking at it, or the PR author added someone specifically which is a stronger notification to the tagged reviewer than the blanket CODEOWNERS behavior. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112813
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0d2b91d with merge base 75adb9f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
After adding support for labeler, we don't need CODEOWNERS. This change will cause the distributed team members previously listed in CODEOWNERS to stop being auto-added as reviewers on PRs touching these files. The preceding PR adds labeler support for these same sets of files, and contains instructions for adding yourself to be cc'd for that label. It is preferable to be auto-cc'd rather than auto-tagged as reviewer, so that there is more signal in the reviewers list (either someone opted in which shows the PR author someone is likely looking at it, or the PR author added someone specifically which is a stronger notification to the tagged reviewer than the blanket CODEOWNERS behavior. [ghstack-poisoned]
After adding support for labeler, we don't need CODEOWNERS. This change will cause the distributed team members previously listed in CODEOWNERS to stop being auto-added as reviewers on PRs touching these files. The preceding PR adds labeler support for these same sets of files, and contains instructions for adding yourself to be cc'd for that label. It is preferable to be auto-cc'd rather than auto-tagged as reviewer, so that there is more signal in the reviewers list (either someone opted in which shows the PR author someone is likely looking at it, or the PR author added someone specifically which is a stronger notification to the tagged reviewer than the blanket CODEOWNERS behavior. ghstack-source-id: bb877ef Pull Request resolved: #112813
|
Should we just let users to remove themselves from the CODEOWNERS? Some people may still want to get the notifications under distributed? |
well, generally we should let people decide for their own settings. But also i think its helpful to totally clear out CODEOWNERS. This is the only way to solve the problem that 'reviewers' are auto-populated, which makes looking at a PR to see who is actually doing a review much harder. So i prefer to just remove everyone from there. However, everyone added to the label issue will still receive notifications. That's bc the bot will @cc them on the issue. So it should be a fairly smooth transition. |
|
@mrshenli @zhaojuanmao @rohan-varma @kiukchung @d4l3k I hesitated about whether to migrate you from CODEOWNERS over to labeler. In the end i did add all of you to labeler, so you'll be CC'd on all the same PRs you used to be tagged on as reviewer. If you are no longer interested in these notifications you can just remove yourself by editing the summary of #24422 directly, no need for a stamp or approval. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 14 jobs have failed, first few of them are: pull / linux-focal-py3.11-clang10 / test (default, 1, 3, linux.2xlarge), pull / linux-focal-py3.11-clang10 / test (crossref, 1, 2, linux.2xlarge), pull / linux-focal-py3.11-clang10 / test (dynamo, 1, 2, linux.2xlarge), pull / linux-focal-py3.8-clang10 / test (default, 1, 3, linux.2xlarge), pull / linux-focal-py3.8-clang10 / test (crossref, 1, 2, linux.2xlarge) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -ic |
|
|
|
@pytorchbot merge -i |
Merge failedReason: 17 jobs have failed, first few of them are: pull / linux-focal-py3.11-clang10 / test (default, 1, 3, linux.2xlarge), pull / linux-focal-py3.11-clang10 / test (crossref, 1, 2, linux.2xlarge), pull / linux-focal-py3.11-clang10 / test (dynamo, 1, 2, linux.2xlarge), pull / linux-focal-py3.8-clang10 / test (default, 1, 3, linux.2xlarge), pull / linux-focal-py3.8-clang10 / test (crossref, 1, 2, linux.2xlarge) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -i |
Merge failedReason: 17 jobs have failed, first few of them are: pull / linux-focal-py3.11-clang10 / test (default, 1, 3, linux.2xlarge), pull / linux-focal-py3.11-clang10 / test (crossref, 1, 2, linux.2xlarge), pull / linux-focal-py3.11-clang10 / test (dynamo, 1, 2, linux.2xlarge), pull / linux-focal-py3.8-clang10 / test (default, 1, 3, linux.2xlarge), pull / linux-focal-py3.8-clang10 / test (crossref, 1, 2, linux.2xlarge) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f"unrelated failures. and also -i wasn't working" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: Command Details for Dev Infra teamRaised by workflow job |
After adding support for labeler, we don't need CODEOWNERS. This change will cause the distributed team members previously listed in CODEOWNERS to stop being auto-added as reviewers on PRs touching these files. The preceding PR adds labeler support for these same sets of files, and contains instructions for adding yourself to be cc'd for that label. It is preferable to be auto-cc'd rather than auto-tagged as reviewer, so that there is more signal in the reviewers list (either someone opted in which shows the PR author someone is likely looking at it, or the PR author added someone specifically which is a stronger notification to the tagged reviewer than the blanket CODEOWNERS behavior. cc H-Huang awgu kwen2501 wanchaol fegin fduwjj wz337 mrshenli zhaojuanmao rohan-varma kiukchung d4l3k [ghstack-poisoned]
After adding support for labeler, we don't need CODEOWNERS. This change will cause the distributed team members previously listed in CODEOWNERS to stop being auto-added as reviewers on PRs touching these files. The preceding PR adds labeler support for these same sets of files, and contains instructions for adding yourself to be cc'd for that label. It is preferable to be auto-cc'd rather than auto-tagged as reviewer, so that there is more signal in the reviewers list (either someone opted in which shows the PR author someone is likely looking at it, or the PR author added someone specifically which is a stronger notification to the tagged reviewer than the blanket CODEOWNERS behavior. ghstack-source-id: 6c62081 Pull Request resolved: #112813
After adding support for labeler, we don't need CODEOWNERS. This change will cause the distributed team members previously listed in CODEOWNERS to stop being auto-added as reviewers on PRs touching these files. The preceding PR adds labeler support for these same sets of files, and contains instructions for adding yourself to be cc'd for that label. It is preferable to be auto-cc'd rather than auto-tagged as reviewer, so that there is more signal in the reviewers list (either someone opted in which shows the PR author someone is likely looking at it, or the PR author added someone specifically which is a stronger notification to the tagged reviewer than the blanket CODEOWNERS behavior. cc H-Huang awgu kwen2501 wanchaol fegin fduwjj wz337 mrshenli zhaojuanmao rohan-varma kiukchung d4l3k [ghstack-poisoned]
After adding support for labeler, we don't need CODEOWNERS. This change will cause the distributed team members previously listed in CODEOWNERS to stop being auto-added as reviewers on PRs touching these files. The preceding PR adds labeler support for these same sets of files, and contains instructions for adding yourself to be cc'd for that label. It is preferable to be auto-cc'd rather than auto-tagged as reviewer, so that there is more signal in the reviewers list (either someone opted in which shows the PR author someone is likely looking at it, or the PR author added someone specifically which is a stronger notification to the tagged reviewer than the blanket CODEOWNERS behavior. ghstack-source-id: 69f50e3 Pull Request resolved: #112813
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
After adding support for labeler, we don't need CODEOWNERS. This change will cause the distributed team members previously listed in CODEOWNERS to stop being auto-added as reviewers on PRs touching these files. The preceding PR adds labeler support for these same sets of files, and contains instructions for adding yourself to be cc'd for that label. It is preferable to be auto-cc'd rather than auto-tagged as reviewer, so that there is more signal in the reviewers list (either someone opted in which shows the PR author someone is likely looking at it, or the PR author added someone specifically which is a stronger notification to the tagged reviewer than the blanket CODEOWNERS behavior. Pull Request resolved: pytorch#112813 Approved by: https://github.com/wanchaol, https://github.com/fduwjj
After adding support for labeler, we don't need CODEOWNERS. This change will cause the distributed team members previously listed in CODEOWNERS to stop being auto-added as reviewers on PRs touching these files. The preceding PR adds labeler support for these same sets of files, and contains instructions for adding yourself to be cc'd for that label. It is preferable to be auto-cc'd rather than auto-tagged as reviewer, so that there is more signal in the reviewers list (either someone opted in which shows the PR author someone is likely looking at it, or the PR author added someone specifically which is a stronger notification to the tagged reviewer than the blanket CODEOWNERS behavior. Pull Request resolved: pytorch#112813 Approved by: https://github.com/wanchaol, https://github.com/fduwjj
albanD
added
oncall: distributed
6 participants
Stack from ghstack (oldest at bottom):
After adding support for labeler, we don't need CODEOWNERS.
This change will cause the distributed team members previously listed in
CODEOWNERS to stop being auto-added as reviewers on PRs touching these
files. The preceding PR adds labeler support for these same sets of
files, and contains instructions for adding yourself to be cc'd for that
label.
It is preferable to be auto-cc'd rather than auto-tagged as reviewer, so
that there is more signal in the reviewers list (either someone opted in
which shows the PR author someone is likely looking at it, or the PR
author added someone specifically which is a stronger notification to
the tagged reviewer than the blanket CODEOWNERS behavior.
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @yf225 @kiukchung @d4l3k @LucasLLC