Skip to content

[LTC] Fix type inference for native_layer_norm_backward #112948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[LTC] Fix type inference for native_layer_norm_backward #112948

wants to merge 1 commit into from

Conversation

GlebKazantaev
Copy link
Contributor

Description

Fix a bug in compute_shape_native_layer_norm_backward function.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 4, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112948

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ce55df2 with merge base add78ac (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 4, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: GlebKazantaev / name: Gleb Kazantaev (ce55df2)

@GlebKazantaev GlebKazantaev force-pushed the gleb/fix_layer_norm_type_infrence branch from 9269c4e to ce55df2 Compare November 4, 2023 10:19
@Skylion007 Skylion007 added the topic: bug fixes topic category label Nov 4, 2023
@Skylion007
Copy link
Collaborator

Could you add a test case to prevent this regression from occurring again?

@GlebKazantaev
Copy link
Contributor Author

Could you add a test case to prevent this regression from occurring again?

To be honest, I don't think that we have any existing test infra that covers shape inference for lazy device. If I understand correctly, custom shape inference functions were added to support ops that have no structured kernels, so no one invested
into tests for this.

CC: @JackCaoG @bdhirsh

@GlebKazantaev
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 6, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@GlebKazantaev
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 6, 2023
@GlebKazantaev
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@GlebKazantaev @xuhancn
[LTC] Fix type inference for native_layer_norm_backward (pytorch#112948)
8522be7 
## Description
Fix a bug in compute_shape_native_layer_norm_backward function.

Pull Request resolved: pytorch#112948
Approved by: https://github.com/Skylion007
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@GlebKazantaev @Skylion007
[LTC] Fix type inference for native_layer_norm_backward (pytorch#112948)
2c2ba09 
## Description
Fix a bug in compute_shape_native_layer_norm_backward function.

Pull Request resolved: pytorch#112948
Approved by: https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: bug fixes topic category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GlebKazantaev @Skylion007 @pytorchmergebot @pytorchbot