Skip to content

[BE] Cleanup sdpa test helper usage #113294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[BE] Cleanup sdpa test helper usage #113294

wants to merge 1 commit into from

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Nov 8, 2023

Summary

standardizes usage of the rand_sdpa_tensor helper

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 8, 2023
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 8, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113294

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8dc1b33 with merge base 740137d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@drisspg drisspg force-pushed the fix_sdpa_testing branch 2 times, most recently from 4fdf78d to eaaef37 Compare November 8, 2023 21:04
@soulitzer
Copy link
Contributor

bikeshed: SpdaShape -> SDPAShape?

@drisspg
Copy link
Contributor Author

drisspg commented Nov 8, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 8, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@drisspg
Copy link
Contributor Author

drisspg commented Nov 8, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@drisspg @Skylion007
[BE] Cleanup sdpa test helper usage (pytorch#113294)
b335b77 
# Summary

standardizes usage of the rand_sdpa_tensor helper

Pull Request resolved: pytorch#113294
Approved by: https://github.com/soulitzer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soulitzer soulitzer soulitzer approved these changes

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drisspg @soulitzer @pytorchmergebot