Skip to content

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Dec 5, 2023

This PR continues to fix clang-tidy warnings for headers in torch/csrc and c10/util.

@cyyever cyyever requested a review from aaronenyeshi as a code owner December 5, 2023 13:03
Copy link

pytorch-bot bot commented Dec 5, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115163

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 2c64668aba70077660586dbb8c8037f5702787cb with merge base 0ee1e46 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever marked this pull request as draft December 5, 2023 13:03
@cyyever
Copy link
Collaborator Author

cyyever commented Dec 5, 2023

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 5, 2023
@cyyever cyyever force-pushed the clang_tidy_torch_csrc5 branch from d2b4870 to 0a3863b Compare December 5, 2023 13:06
@cyyever cyyever changed the title Fix clang-tidy warnings [4/N] Fixes clang-tidy warnings in header files Dec 5, 2023
@cyyever cyyever force-pushed the clang_tidy_torch_csrc5 branch from 66c539c to 48fe1bf Compare December 5, 2023 14:28
@cyyever cyyever marked this pull request as ready for review December 5, 2023 16:27
Copy link
Collaborator

@Skylion007 Skylion007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem rather benign.

@cyyever
Copy link
Collaborator Author

cyyever commented Dec 6, 2023

@pytorchbot label ciflow/trunk

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 6, 2023
@cyyever
Copy link
Collaborator Author

cyyever commented Dec 6, 2023

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the clang_tidy_torch_csrc5 branch December 6, 2023 05:23
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants