Skip to content

[BE]: Enable RUFF PERF402 and apply fixes #115505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[BE]: Enable RUFF PERF402 and apply fixes #115505

wants to merge 5 commits into from

Conversation

Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented Dec 10, 2023 •
edited
Loading

  • Enable PERF402. Makes code more efficient and succinct by removing useless list copies that could be accomplished either via a list constructor or extend call. All test cases have noqa added since performance is not as sensitive in that folder.

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 10, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115505

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 84efbdd with merge base af8a50e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added oncall: distributed Add this issue/PR to distributed oncall triage queue module: cpu CPU specific problem (e.g., perf, algorithm) module: inductor ciflow/inductor labels Dec 10, 2023
@Skylion007 Skylion007 force-pushed the skylion007/ruff-PERF402-enable-2023-12-10 branch from 5e3e68c to cfc417c Compare December 10, 2023 17:46
malfet
malfet approved these changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I would prefer to update test cases (except for jit, that might not support .extend) as well

@Skylion007 Skylion007 force-pushed the skylion007/ruff-PERF402-enable-2023-12-10 branch from 09e83c4 to 550f41f Compare December 10, 2023 19:13
@Skylion007 Skylion007 added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 10, 2023
@Skylion007
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@Skylion007 Skylion007 added the topic: not user facing topic category label Dec 10, 2023
@Skylion007
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@Skylion007
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 4 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@Skylion007
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

@albanD albanD removed their request for review December 11, 2023 16:46
@Skylion007
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased skylion007/ruff-PERF402-enable-2023-12-10 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout skylion007/ruff-PERF402-enable-2023-12-10 && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the skylion007/ruff-PERF402-enable-2023-12-10 branch from abcfc8e to 84efbdd Compare December 20, 2023 15:15
@Skylion007
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
@Skylion007 @dmenig
[BE]: Enable RUFF PERF402 and apply fixes (pytorch#115505)
8c15934 
* Enable PERF402. Makes code more efficient and succinct by removing useless list copies that could be accomplished either via a list constructor or extend call. All test cases have noqa added since performance is not as sensitive in that folder.

Pull Request resolved: pytorch#115505
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@BowenBao BowenBao Awaiting requested review from BowenBao

@abock abock Awaiting requested review from abock

@thiagocrepaldi thiagocrepaldi Awaiting requested review from thiagocrepaldi

@wschin wschin Awaiting requested review from wschin

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168 jerryzh168 is a code owner

@HDCharles HDCharles Awaiting requested review from HDCharles

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: inductor oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: AO frontend topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Skylion007 @pytorchmergebot @malfet @pytorchbot