Skip to content

Fixed a segfault issue when passing an empty kernel to quantized_max_… #116342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fixed a segfault issue when passing an empty kernel to quantized_max_… #116342

wants to merge 3 commits into from

Conversation

@tringwald
Copy link
Collaborator

@tringwald tringwald commented Dec 22, 2023 •
edited by pytorch-bot bot
Loading

…pool1d.

Fixes #116323.

Reused the same check as for max_pool1d.

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10

@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Dec 22, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 22, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116342

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b4ebfbf with merge base 0b9146b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Dec 22, 2023
Skylion007
Skylion007 reviewed Dec 24, 2023
View reviewed changes
jerryzh168
jerryzh168 approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tringwald
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 26, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@jerryzh168 jerryzh168 jerryzh168 approved these changes

@salilsdesai salilsdesai Awaiting requested review from salilsdesai salilsdesai is a code owner

@kimishpatel kimishpatel Awaiting requested review from kimishpatel kimishpatel is a code owner

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

@jianyuh jianyuh Awaiting requested review from jianyuh jianyuh is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) open source release notes: quantization release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

torch.quantized_max_pool1d: Segfault

5 participants

@tringwald @pytorchmergebot @Skylion007 @jerryzh168 @pytorchbot