-
Notifications
You must be signed in to change notification settings - Fork 25.6k
BugFix: Fix F632 bug in dynamo (if statement is always false) #116867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BugFix: Fix F632 bug in dynamo (if statement is always false) #116867
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116867
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (5 Unrelated Failures)As of commit 6ab7e36 with merge base 0159e3a ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
return args[0].call_method(tx, "size", [args[1]], {}) | ||
elif ( | ||
self.value is [torch.ops.aten.sym_stride, torch.ops.aten.sym_stride.int] | ||
self.value in (torch.ops.aten.sym_stride, torch.ops.aten.sym_stride.int) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also micro-optimized the lists into this file into tuples which are cheaper to construct.
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM nice catch!
This was flagged by a preview ruff check as the if statement always evaluating false. Likely a typo between
is
andin
. I also micro-optimized some list construction into tuple construction, which is semantically identical, but faster.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng