Skip to content

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Feb 10, 2024

For the proper exception handling, otherwise raising C++ exception inside dispatch block will crash the app (discovered while enabling more BFloat16 ops)

…uous`

Just for the proper exception handling
@malfet malfet requested review from Skylion007 and albanD February 10, 2024 22:53
@malfet malfet requested a review from kulinseth as a code owner February 10, 2024 22:53
@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Feb 10, 2024
Copy link

pytorch-bot bot commented Feb 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119646

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e354ed4 with merge base 6db6a1b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet added the topic: bug fixes topic category label Feb 11, 2024
@malfet
Copy link
Contributor Author

malfet commented Feb 11, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 11, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet deleted the malfet-patch-17 branch February 11, 2024 16:22
clee2000 pushed a commit that referenced this pull request Feb 14, 2024
For the proper exception handling, otherwise raising C++ exception inside dispatch block will crash the app (discovered while enabling more BFloat16 ops)

Pull Request resolved: #119646
Approved by: https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: mps Release notes category topic: bug fixes topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants