-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Skip log line if no tensors were dedupped #119742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119742
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 75c2941 with merge base 74d55b0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot merge |
Please seek CI approval before scheduling CIFlow labels |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
@pytorchbot label "topic: not user facing" |
@pytorchbot merge |
Please seek CI approval before scheduling CIFlow labels |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@mvpatel2000 btw this method of dedup is being deprecated in favor of: https://github.com/pytorch/pytorch/blob/main/torch/distributed/checkpoint/_dedup_save_plans.py which fwiw omits the log all together |
Skips log line if nothing was dedupped. Avoids unhelpful logs like:
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @LucasLLC