-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[inductor] When generating debug logs don't fail if nvcc not found #120346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If nvcc isn't found subprocess throws a CalledProcessError Differential Revision: [D54028438](https://our.internmc.facebook.com/intern/diff/D54028438/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120346
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 6 Unrelated FailuresAs of commit 3d2e9f5 with merge base cc7ef43 ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D54028438 |
If nvcc isn't found subprocess throws a CalledProcessError Differential Revision: [D54028438](https://our.internmc.facebook.com/intern/diff/D54028438/) ghstack-source-id: 215963556 Pull Request resolved: #120346
comment = "".join([f"# {s} \n" for s in cuda_version_lines if s not in [""]]) | ||
model_str += f"{comment}\n" | ||
except FileNotFoundError: | ||
except (FileNotFoundError, subprocess.CalledProcessError): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need FileNotFoundError then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, so actually it's a little more complex than in my summary, if nvcc simply isn't there we'll get a FileNotFoundError
, but in my case I have nvcc symlinked to ccache (as recommended in our dev setup guide) but no nvcc in my path. I think it's still valid to catch both here :)
@pytorchbot merge -f "Failure seems flaky/unrelated" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
If nvcc isn't found subprocess throws a CalledProcessError
Differential Revision: D54028438
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng