[Clang-tidy header][21/N] Fix clang-tidy warnings in aten/src/ATEN/*.{cpp,h} #120763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120763
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 064e949 with merge base ab38354 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cyyever
force-pushed
the
clang_tidy_torch_csrc23
branch
from
6f99325 to
302eb7b
Compare
cyyever
force-pushed
the
clang_tidy_torch_csrc23
branch
2 times, most recently
from
512ba94 to
e70f904
Compare
cyyever
changed the title
janeyx99
added
triaged
Skylion007
approved these changes
Feb 28, 2024
Skylion007
requested changes
Feb 28, 2024
Skylion007
reviewed
Feb 28, 2024
cyyever
force-pushed
the
clang_tidy_torch_csrc23
branch
from
e70f904 to
064e949
Compare
|
@pytorchbot label ciflow/trunk |
|
@pytorchmergebot merge |
|
This PR needs to be approved by an authorized maintainer before merge. |
|
@Skylion007 Pin you to review the new updates... |
Skylion007
approved these changes
Mar 3, 2024
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 6, 2024
…{cpp,h} (#121102)
This PR continues to fix clang-tidy warnings in aten/src/ATEN/*, following #120763.
Pull Request resolved: #121102
Approved by: https://github.com/Skylion007
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 7, 2024
…/*.{cpp,h} (#121380)
This PR finishes the works beginning with ##120763 by enabling clang-tidy on aten/src/ATen.
Pull Request resolved: #121380
Approved by: https://github.com/Skylion007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues to fix clang-tidy warnings in aten/src/ATEN/*, following #120574.