[export] Log module hierarchy. #121970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

zhxchen17 wants to merge 1 commit into pytorch:main from zhxchen17:export-D54921097

Contributor

zhxchen17 commented Mar 15, 2024

Summary:
We can also log the module hierarchy in the following format:

:ToplevelModule
sparse:SparshArch
dense:DenseArch

So that we can have more information recorded about model's identity.

Test Plan: CI

Differential Revision: D54921097

zhxchen17 requested review from avikchaudhuri, gmagogsfm and tugsbayasgalan as code owners

March 15, 2024 14:46

pytorch-bot bot commented Mar 15, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121970

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit d2d5937 with merge base 11b36e1 ():

NEW FAILURE - The following job has failed:

pull / linux-jammy-py3.8-gcc11 / build (gh)
Could not assume role with user credentials: User: arn:aws:sts::308535385114:assumed-role/gh-ci-github-action-runners-runner-role/i-0ec667b3b5fa4b0d5 is not authorized to perform: sts:TagSession on resource: arn:aws:iam::391835788720:role/gha-pytorch-ci-artifacts-role

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Contributor

facebook-github-bot commented Mar 15, 2024

This pull request was exported from Phabricator. Differential Revision: D54921097

facebook-github-bot added the fb-exported label

zhxchen17 force-pushed the export-D54921097 branch from c0f6bcd to 74315cc Compare

March 15, 2024 14:47

Contributor

facebook-github-bot commented Mar 15, 2024

This pull request was exported from Phabricator. Differential Revision: D54921097

zhxchen17 force-pushed the export-D54921097 branch from 74315cc to bcab1f4 Compare

March 15, 2024 17:03

Contributor

facebook-github-bot commented Mar 15, 2024

This pull request was exported from Phabricator. Differential Revision: D54921097

zhxchen17 force-pushed the export-D54921097 branch from bcab1f4 to 183b063 Compare

March 15, 2024 17:04

Contributor

facebook-github-bot commented Mar 15, 2024

This pull request was exported from Phabricator. Differential Revision: D54921097

Skylion007 reviewed

View reviewed changes

torch/export/_trace.py Outdated

Collaborator

Skylion007 Mar 15, 2024

nit can be a dict comprehension

zhxchen17 force-pushed the export-D54921097 branch from 183b063 to 668f5bd Compare

March 15, 2024 18:31

Contributor

facebook-github-bot commented Mar 15, 2024

This pull request was exported from Phabricator. Differential Revision: D54921097

zhxchen17 force-pushed the export-D54921097 branch from 668f5bd to 05198e5 Compare

March 15, 2024 18:32

Contributor

facebook-github-bot commented Mar 15, 2024

This pull request was exported from Phabricator. Differential Revision: D54921097

zhxchen17 force-pushed the export-D54921097 branch from 05198e5 to faf814f Compare

March 15, 2024 20:00

Contributor

facebook-github-bot commented Mar 15, 2024

This pull request was exported from Phabricator. Differential Revision: D54921097

zhxchen17 force-pushed the export-D54921097 branch from faf814f to 1bfc9ea Compare

March 18, 2024 15:44

Contributor

facebook-github-bot commented Mar 18, 2024

This pull request was exported from Phabricator. Differential Revision: D54921097


          [export] Log module hierarchy. (pytorch#121970)

d2d5937

Summary:

We can also log the module hierarchy in the following format:
```
:ToplevelModule
sparse:SparshArch
dense:DenseArch
```
So that we can have more information recorded about model's identity.

Test Plan: CI

Differential Revision: D54921097

zhxchen17 force-pushed the export-D54921097 branch from 1bfc9ea to d2d5937 Compare

March 18, 2024 15:45

Contributor

facebook-github-bot commented Mar 18, 2024

This pull request was exported from Phabricator. Differential Revision: D54921097

angelayi approved these changes

View reviewed changes

pytorch-bot bot added the ciflow/trunk label

Contributor

facebook-github-bot commented Mar 20, 2024

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Mar 20, 2024

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised by workflow job

pytorchmergebot removed the merging label

Contributor

izaitsevfb commented Mar 20, 2024 •

edited

Loading

@zhxchen17, @angelayi , could you please add relevant label and re-merge?

zhxchen17 added the topic: not user facing label

Contributor Author

zhxchen17 commented Mar 20, 2024

@pytorchbot merge

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Mar 20, 2024

Merge failed

Reason: [Errno 104] Connection reset by peer

Details for Dev Infra team

Raised by workflow job

pytorchmergebot removed the merging label

Contributor Author

zhxchen17 commented Mar 20, 2024

@pytorchbot merge

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Mar 20, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Collaborator

pytorchmergebot commented Mar 20, 2024

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

pull / linux-jammy-py3.8-gcc11 / build

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

pytorchmergebot removed the merging label

Contributor

huydhn commented Mar 20, 2024

@pytorchbot merge -i

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Mar 20, 2024

Merge started

Your change will be merged while ignoring the following 1 checks: pull / linux-jammy-py3.8-gcc11 / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot closed this in

d1e8b97

pytorchmergebot added Merged and removed merging labels

pytorch-bot bot pushed a commit that referenced this pull request


          [export] Log module hierarchy. (#121970)

9fa6a87

Summary:
We can also log the module hierarchy in the following format:
```
:ToplevelModule
sparse:SparshArch
dense:DenseArch
```
So that we can have more information recorded about model's identity.

Test Plan: CI

Differential Revision: D54921097

Pull Request resolved: #121970
Approved by: https://github.com/angelayi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Skylion007 Skylion007 left review comments

angelayi angelayi approved these changes

avikchaudhuri Awaiting requested review from avikchaudhuri avikchaudhuri is a code owner

gmagogsfm Awaiting requested review from gmagogsfm

tugsbayasgalan Awaiting requested review from tugsbayasgalan tugsbayasgalan is a code owner

Labels

ciflow/trunk fb-exported Merged topic: not user facing