-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[BE] Remove unnecessary state dict update. #122528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
From what I can see, following is a redundant/unnecessary setting of dict element. Differential Revision: [D55191396](https://our.internmc.facebook.com/intern/diff/D55191396/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122528
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit eee8dcc with merge base 48afb5c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D55191396 |
From what I can see, following is a redundant/unnecessary setting of dict element. Differential Revision: [D55191396](https://our.internmc.facebook.com/intern/diff/D55191396/) ghstack-source-id: 219747096 Pull Request resolved: #122528
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
From what I can see, following is a redundant/unnecessary setting of dict element. Differential Revision: [D55191396](https://our.internmc.facebook.com/intern/diff/D55191396/) Pull Request resolved: #122528 Approved by: https://github.com/Skylion007
Stack from ghstack (oldest at bottom):
From what I can see, following is a redundant/unnecessary setting of dict element.
Differential Revision: D55191396
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang