Add bfloat16 support to binary_cross_entropy for CPU

[FFFrog]

Fixes #123715

As the title stated.

But, maybe we should pay attention to this #33206, which removed the half support for cpu about 4 years ago.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/123823

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8044c54 with merge base 236b0d1 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[FFFrog]

@pytorchbot merge

[pytorchmergebot]

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised by workflow job

[malfet]

Should we create some sort of a new issues, as a lot of things has happened since 4 years ago, for example CPU no longer equals x86_64 only, and on ARM half support makes a lot of sense. But there are also precision consideration

[malfet]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[pytorchmergebot]

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

• pull / linux-focal-py3.12-clang10 / test (dynamo, 1, 3, linux.2xlarge)
• pull / linux-focal-py3.12-clang10 / test (dynamo, 2, 3, linux.2xlarge)
• pull / linux-focal-py3.12-clang10 / test (dynamo, 3, 3, linux.2xlarge)

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

[malfet]

@FFFrog looks you've uncovered a bug in MPS binary cross-entropy implementation

test_mps.py::TestConsistencyCPU::test_output_match_nn_functional_binary_cross_entropy_cpu_float16 loc("mps_subtract"("(mpsFileLoc): /AppleInternal/Library/BuildRoots/9e200cfa-7d96-11ed-886f-a23c4f261b56/Library/Caches/com.apple.xbs/Sources/MetalPerformanceShadersGraph/mpsgraph/MetalPerformanceShadersGraph/Core/Files/MPSGraphUtilities.mm":228:0)): error: input types 'tensor<f32>' and 'tensor<1xf16>' are not broadcast compatible

Please file an issue and disable the test for this dtype (there is a skip list)

[FFFrog]

@FFFrog looks you've uncovered a bug in MPS binary cross-entropy implementation

test_mps.py::TestConsistencyCPU::test_output_match_nn_functional_binary_cross_entropy_cpu_float16 loc("mps_subtract"("(mpsFileLoc): /AppleInternal/Library/BuildRoots/9e200cfa-7d96-11ed-886f-a23c4f261b56/Library/Caches/com.apple.xbs/Sources/MetalPerformanceShadersGraph/mpsgraph/MetalPerformanceShadersGraph/Core/Files/MPSGraphUtilities.mm":228:0)): error: input types 'tensor<f32>' and 'tensor<1xf16>' are not broadcast compatible

Please file an issue and disable the test for this dtype (there is a skip list)

Thank you for your reply. I will file an issue about this.

[FFFrog]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here