Remove global variable SIZE, and fix linter warning #128559
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128559
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f0baa51 with merge base 67e6c76 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kit1980
approved these changes
Jun 12, 2024
yushangdi
changed the title
yushangdi
changed the title
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Skylion007
approved these changes
Jun 13, 2024
Merge failedReason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 3, 3, macos-m1-stable) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
TharinduRusira
pushed a commit
to TharinduRusira/pytorch
that referenced
this pull request
Jun 14, 2024
- Resolve a TODO by removing global variable `SIZE`. - Fix a linter warning in `test/test_nestedtensor.py`. `pytest pytorch/test/test_sort_and_select.py` and ` pytest test/test_nestedtensor.py` pass. Pull Request resolved: pytorch#128559 Approved by: https://github.com/kit1980, https://github.com/Skylion007
ignaciobartol
pushed a commit
to ignaciobartol/pytorch
that referenced
this pull request
Jun 14, 2024
- Resolve a TODO by removing global variable `SIZE`. - Fix a linter warning in `test/test_nestedtensor.py`. `pytest pytorch/test/test_sort_and_select.py` and ` pytest test/test_nestedtensor.py` pass. Pull Request resolved: pytorch#128559 Approved by: https://github.com/kit1980, https://github.com/Skylion007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIZE.test/test_nestedtensor.py.pytest pytorch/test/test_sort_and_select.pyandpytest test/test_nestedtensor.pypass.