-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[dynamo] Support object.__new__ call #133746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133746
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 49c061c with merge base fb59440 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use "is" instead of equality check here, object is a singleton.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Actually if you could handle the other "==" -> is in this method in the PR stack, that would be super helpful. Thanks.
Will do in a few hours. |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Pull Request resolved: #133935 Approved by: https://github.com/williamwen42, https://github.com/jansel ghstack dependencies: #133745, #133747, #133746, #133799, #133800
… defined class (pytorch#133799) Pull Request resolved: pytorch#133799 Approved by: https://github.com/jansel ghstack dependencies: pytorch#133745, pytorch#133747, pytorch#133746
Pull Request resolved: pytorch#133800 Approved by: https://github.com/jansel ghstack dependencies: pytorch#133745, pytorch#133747, pytorch#133746, pytorch#133799
Pull Request resolved: pytorch#133935 Approved by: https://github.com/williamwen42, https://github.com/jansel ghstack dependencies: pytorch#133745, pytorch#133747, pytorch#133746, pytorch#133799, pytorch#133800
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames