-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[dynamo] fix polyfill for user defined constructor __new__
#133822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133822
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f140a0e with merge base 022cd7c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
In `cls->tp_call`, if `cls->tp_new` does not return a instance of class `cls`, then `cls->tp_init` is not called on the new instance. ghstack-source-id: a7c521a Pull Request resolved: pytorch#133822
In `cls->tp_call`, if `cls->tp_new` does not return a instance of class `cls`, then `cls->tp_init` is not called on the new instance. ghstack-source-id: 5cf310c Pull Request resolved: pytorch#133822
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
__new__#133822In
cls->tp_call, ifcls->tp_newdoes not return an instance of classcls, thencls->tp_initis not called on the new instance.Related PR:
cc @rec @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @xmfan