Skip to content

Conversation

@XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Aug 18, 2024

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133822

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f140a0e with merge base 022cd7c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@XuehaiPan XuehaiPan requested a review from jansel August 19, 2024 18:47
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@XuehaiPan XuehaiPan added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 20, 2024
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Aug 20, 2024
In `cls->tp_call`, if `cls->tp_new` does not return a instance of class `cls`, then `cls->tp_init` is not called on the new instance.

ghstack-source-id: a7c521a
Pull Request resolved: pytorch#133822
[ghstack-poisoned]
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Aug 20, 2024
In `cls->tp_call`, if `cls->tp_new` does not return a instance of class `cls`, then `cls->tp_init` is not called on the new instance.

ghstack-source-id: 5cf310c
Pull Request resolved: pytorch#133822
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Aug 21, 2024
In `cls->tp_call`, if `cls->tp_new` does not return a instance of class `cls`, then `cls->tp_init` is not called on the new instance.

ghstack-source-id: 0707e74
Pull Request resolved: #133822
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/XuehaiPan/155/head branch October 1, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants