Skip to content

[dynamo][fix] always use POSIX-style path in trace_rule.py #133987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

[dynamo][fix] always use POSIX-style path in trace_rule.py #133987

wants to merge 8 commits into from

Conversation

XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Aug 20, 2024 •
edited
Loading

@XuehaiPan
Update
a0427ac 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 20, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/133987

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 035e9f4 with merge base 75c22dd (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@XuehaiPan XuehaiPan changed the title [dynamo] always use POSIX-style path in trace_rule.py [dynamo][fix] always use POSIX-style path in trace_rule.py Aug 20, 2024
@XuehaiPan XuehaiPan requested a review from yanboliang August 20, 2024 09:34
This was referenced Aug 20, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@XuehaiPan XuehaiPan added module: windows Windows support for PyTorch topic: bug fixes topic category release notes: dynamo labels Aug 20, 2024
@XuehaiPan
Update
71c7e6c 
[ghstack-poisoned]
@XuehaiPan XuehaiPan added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 20, 2024
XuehaiPan added a commit that referenced this pull request Aug 20, 2024
@XuehaiPan
[dynamo] always use POSIX-style path in trace_rule.py
aa27ebd 
We are hardcoding some path in string in POSIX style. This will lead to different results on Windows. This PR force all paths to be in POSIX-style.

ghstack-source-id: b405548
Pull Request resolved: #133987
@XuehaiPan XuehaiPan mentioned this pull request Aug 21, 2024
Closed
@XuehaiPan
Update
b0423bc 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Aug 21, 2024
@XuehaiPan
[dynamo] always use POSIX-style path in trace_rule.py
a546007 
We are hardcoding some path in string in POSIX style. This will lead to different results on Windows. This PR force all paths to be in POSIX-style.

ghstack-source-id: 7b40ac0
Pull Request resolved: #133987
@XuehaiPan XuehaiPan added the ci-test-showlocals Show local variables on test failures label Aug 21, 2024
@albanD
Copy link
Collaborator

albanD commented Aug 23, 2024

@pytorchbot revert -m "This breaks windows trunk jobs" -c nosignal

See https://hud.pytorch.org/pytorch/pytorch/commit/b23779ef0af8d4f06e667da460c43d264359f1f0 for example failures

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@XuehaiPan your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Aug 23, 2024
@pytorchmergebot
Revert "[dynamo][fix] always use POSIX-style path in trace_rule.py (#…
75c22dd 
…133987)"

This reverts commit b23779e.

Reverted #133987 on behalf of https://github.com/albanD due to This breaks windows trunk jobs ([comment](#133987 (comment)))
@XuehaiPan
Update
035e9f4 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Aug 23, 2024
@XuehaiPan
[dynamo] always use POSIX-style path in trace_rule.py
87c33ad 
We are hardcoding some path in string in POSIX style. This will lead to different results on Windows. This PR force all paths to be in POSIX-style.

ghstack-source-id: 3c27722
Pull Request resolved: pytorch#133987
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge -f "all tests pass, stuck at rocm ci queue"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Aug 27, 2024
@XuehaiPan @pytorchmergebot
[BE][Easy][dynamo] ensure trace_rules.MOD_INLINELIST in alphabetica…
d014729 
…l order (#134246)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):

* __->__ #134246
* #133987

Pull Request resolved: #134246
Approved by: https://github.com/yanboliang
@vadym-janea vadym-janea mentioned this pull request Aug 29, 2024
Closed
@ghost ghost mentioned this pull request Aug 29, 2024
Closed
pytorchmergebot pushed a commit that referenced this pull request Sep 6, 2024
@vadym-janea @pytorchmergebot
Revert expectFailureIf condition on tests with torch.compile on Windo…
a7643ba 
…ws (#134759)

Fixes #134716

This PR reverts some changes introduced in 6eae569 (#133987)

torch.compile is not available on Windows, tests should be expected to fail.

Pull Request resolved: #134759
Approved by: https://github.com/malfet
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@XuehaiPan @Chao1Han
[BE][Easy][dynamo] ensure trace_rules.MOD_INLINELIST in alphabetica…
811021b 
…l order (pytorch#134246)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):

* __->__ pytorch#134246
* pytorch#133987

Pull Request resolved: pytorch#134246
Approved by: https://github.com/yanboliang
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@vadym-janea @Chao1Han
Revert expectFailureIf condition on tests with torch.compile on Windo…
ce28d4c 
…ws (pytorch#134759)

Fixes pytorch#134716

This PR reverts some changes introduced in pytorch@6eae569 (pytorch#133987)

torch.compile is not available on Windows, tests should be expected to fail.

Pull Request resolved: pytorch#134759
Approved by: https://github.com/malfet
@github-actions github-actions bot deleted the gh/XuehaiPan/167/head branch October 1, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@yanboliang yanboliang Awaiting requested review from yanboliang

@Skylion007 Skylion007 Awaiting requested review from Skylion007

@anijain2305 anijain2305 Awaiting requested review from anijain2305

Assignees

No one assigned

Labels

ci-test-showlocals Show local variables on test failures ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: windows Windows support for PyTorch open source release notes: dynamo Reverted topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@XuehaiPan @pytorchmergebot @albanD @jansel @pytorchbot