[EZ] Restore test_unicode_comments
#134589
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts changes introduced by test_jit.py by 43737bd and adds lint suppression for this it
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134589
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 2295b45 with merge base 13114da ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
aorenste
approved these changes
Aug 27, 2024
Skylion007
approved these changes
Aug 27, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Hmm, I expect it to fail some sort of a lint rule against unicode characters... |
|
It's possible that in #124771 that after hitting the flake8 error a bunch of times I was overzealous about expunging non-ascii chars and this particular line never caused flake8 to complain. |
pytorch-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
This reverts changes introduced by test_jit.py by 43737bd and adds lint suppression for this it As test name suggests it should have an unicode comment to make sure our parser can handle it Part of the fix for #134422 Pull Request resolved: #134589 Approved by: https://github.com/aorenste, https://github.com/Skylion007
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
This reverts changes introduced by test_jit.py by pytorch@43737bd and adds lint suppression for this it As test name suggests it should have an unicode comment to make sure our parser can handle it Part of the fix for pytorch#134422 Pull Request resolved: pytorch#134589 Approved by: https://github.com/aorenste, https://github.com/Skylion007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts changes introduced by test_jit.py by 43737bd and adds lint suppression for this it
As test name suggests it should have an unicode comment to make sure our parser can handle it
Part of the fix for #134422