Add README to tools, delete defunct scripts.#13621
Closed
ezyang wants to merge 1 commit intopytorch:masterfrom
Closed
Add README to tools, delete defunct scripts.#13621ezyang wants to merge 1 commit intopytorch:masterfrom
ezyang wants to merge 1 commit intopytorch:masterfrom
Conversation
Some extra documentation for other bits too. Signed-off-by: Edward Z. Yang <ezyang@fb.com>
facebook-github-bot
added
the
oncall: jit
soumith
approved these changes
Nov 6, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
I think this commit is wrong, at least https://github.com/pytorch/pytorch/blob/master/tools/README.md seems so. Its doubling 'tools' in all urls, I guess it takes its parent folder (tools) as a basedir and adding tools/ to links its doubling that, resulting in links like https://github.com/pytorch/pytorch/blob/master/tools/tools/autograd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some extra documentation for other bits too.
Signed-off-by: Edward Z. Yang ezyang@fb.com