[BE][clang-format] make macro PyObject_HEAD have its own line
#136945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuehaiPan
requested review from
EikanWang,
aaronenyeshi,
albanD,
eqy,
gujinghui,
soulitzer,
sraikund16 and
syed-ahmed
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136945
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4a84051 with merge base 862029a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
XuehaiPan
added
module: lint
XuehaiPan
commented
Sep 29, 2024
| SpacesInCStyleCastParentheses: false | ||
| SpacesInParentheses: false | ||
| SpacesInSquareBrackets: false | ||
| Standard: Cpp11 |
There was a problem hiding this comment.
Cpp11 is deprecated: https://clang.llvm.org/docs/ClangFormatStyleOptions.html#standard
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 2, 2024
…ject_HEAD_INIT(type, size)` have its own line (#136949) Pull Request resolved: #136949 Approved by: https://github.com/albanD, https://github.com/eqy ghstack dependencies: #136945
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
PyObject_HEAD_INIT(type)andPyVarObject_HEAD_INIT(type, size)have its own line #136949PyObject_HEADhave its own line #136945cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @rec