Skip to content

Improve ASAN path detection #137865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Improve ASAN path detection #137865

wants to merge 2 commits into from

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Oct 13, 2024 •
edited
Loading

Follows #137335, for better adoption of latest clang to ASAN jobs.

@cyyever cyyever requested a review from a team as a code owner October 13, 2024 14:04
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 13, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137865

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8d1e08c with merge base 4470339 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever marked this pull request as draft October 13, 2024 14:05
@cyyever
Copy link
Collaborator Author

cyyever commented Oct 13, 2024

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 13, 2024
@cyyever cyyever force-pushed the clang18_asan_ci2 branch 2 times, most recently from 881d2b3 to d991b41 Compare October 13, 2024 14:12
@cyyever cyyever marked this pull request as ready for review October 13, 2024 22:36
@cyyever cyyever changed the title Improve asan15 paths Improve ASAN path detection Oct 13, 2024
@cyyever cyyever requested review from desertfire and ezyang and removed request for desertfire October 13, 2024 22:48
Skylion007
Skylion007 reviewed Oct 14, 2024
View reviewed changes
@cyyever
Copy link
Collaborator Author

cyyever commented Oct 14, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

cyyever and others added 2 commits October 14, 2024 23:30
@cyyever @pytorchmergebot
Improve ASAN paths
b8b30e7 
Signed-off-by: cyy <cyyever@outlook.com>
@cyyever @Skylion007 @pytorchmergebot
Update .ci/pytorch/test.sh
8d1e08c 
Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com>
@pytorchmergebot
Copy link
Collaborator

Successfully rebased clang18_asan_ci2 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout clang18_asan_ci2 && git pull --rebase)

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 14, 2024

@pytorchmergebot merge -f "CI passed"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the clang18_asan_ci2 branch October 22, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cyyever @pytorchmergebot @Skylion007 @pytorchbot