Skip to content

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Oct 21, 2024

Copy link

pytorch-bot bot commented Oct 21, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/138465

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6870be5 with merge base 5a13282 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever marked this pull request as draft October 21, 2024 14:38
@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category labels Oct 21, 2024
@cyyever cyyever force-pushed the tidy_distribu_c10_2 branch 3 times, most recently from 40c7ba0 to 89c1ee2 Compare October 22, 2024 00:57
@cyyever cyyever force-pushed the tidy_distribu_c10_2 branch from 89c1ee2 to 6870be5 Compare October 22, 2024 08:28
@cyyever cyyever marked this pull request as ready for review October 23, 2024 09:37
@cyyever cyyever changed the title Fix clang-tidy warnings [Distributed] [17/N] Fix clang-tidy warnings in torch/csrc/distributed/ Oct 23, 2024
@cyyever cyyever requested a review from kwen2501 October 23, 2024 09:39
@colesbury colesbury requested a review from Skylion007 October 23, 2024 20:08
@colesbury colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 23, 2024
@cyyever cyyever requested a review from ezyang October 24, 2024 02:33
@ezyang
Copy link
Contributor

ezyang commented Oct 24, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 24, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever
Copy link
Collaborator Author

cyyever commented Oct 24, 2024

@pytorchmergebot merge -f "Pending job"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the tidy_distribu_c10_2 branch October 29, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: distributed (c10d) release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants