Workaround torch.deploy failures #139195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

malfet wants to merge 1 commit into pytorch:main from malfet:export-D65145409

Contributor

malfet commented Oct 29, 2024 •

edited

Loading

Summary:
Which are backed with an older version of typing_extensoins but this runtime could not care less about type-checking.
So pretend that is has TypeIs by replacing it with TypeGuard

Fixes test failures introduced by #133814 / D65030974

Test Plan: buck2 test 'fbcode//mode/opt' fbcode//multipy/runtime:test_deploy -- --exact 'multipy/runtime:test_deploy - TorchpyTest.TestNumpy'

Differential Revision: D65145409

pytorch-bot bot commented Oct 29, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139195

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d4d4600 with merge base a884462 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Contributor

facebook-github-bot commented Oct 29, 2024

This pull request was exported from Phabricator. Differential Revision: D65145409

facebook-github-bot added the fb-exported label

malfet requested a review from Skylion007

October 29, 2024 14:44

malfet added release notes: python_frontend topic: fuzzer labels

Skylion007 approved these changes

View reviewed changes

pytorch-bot bot added the ciflow/trunk label

malfet force-pushed the export-D65145409 branch from bd09288 to 3034bcf Compare

October 29, 2024 16:48

malfet force-pushed the export-D65145409 branch from 3034bcf to 9d78345 Compare

October 29, 2024 16:48

Contributor

facebook-github-bot commented Oct 29, 2024

This pull request was exported from Phabricator. Differential Revision: D65145409

1 similar comment

Contributor

facebook-github-bot commented Oct 29, 2024

This pull request was exported from Phabricator. Differential Revision: D65145409

malfet force-pushed the export-D65145409 branch from 9d78345 to 44a9790 Compare

October 29, 2024 17:19

Contributor

facebook-github-bot commented Oct 29, 2024

This pull request was exported from Phabricator. Differential Revision: D65145409


          Workaround torch.deploy failures (pytorch#139195)

d4d4600

Summary:

Which are backed with an older version of `typing_extensoins` but this runtime could not care less about type-checking.
So pretend that is has `TypeIs` by replacing it with `TypeGuard`

Fixes test failures introduced by pytorch#133814 / D65030974

Test Plan: `buck2 test 'fbcode//mode/opt' fbcode//multipy/runtime:test_deploy -- --exact 'multipy/runtime:test_deploy - TorchpyTest.TestNumpy'`

Reviewed By: s4ayub, sayitmemory

Differential Revision: D65145409

malfet force-pushed the export-D65145409 branch from 44a9790 to d4d4600 Compare

October 29, 2024 18:26

Contributor

facebook-github-bot commented Oct 29, 2024

This pull request was exported from Phabricator. Differential Revision: D65145409

Contributor

facebook-github-bot commented Oct 29, 2024

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Oct 29, 2024

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot closed this in

bd369bb

pytorchmergebot added Merged and removed merging labels

rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request


          Workaround torch.deploy failures (pytorch#139195)

75a2bf9

Summary:
Which are backed with an older version of `typing_extensoins` but this runtime could not care less about type-checking.
So pretend that is has `TypeIs` by replacing it with `TypeGuard`

Fixes test failures introduced by pytorch#133814 / D65030974

Test Plan: `buck2 test 'fbcode//mode/opt' fbcode//multipy/runtime:test_deploy -- --exact 'multipy/runtime:test_deploy - TorchpyTest.TestNumpy'`

Differential Revision: D65145409

Pull Request resolved: pytorch#139195
Approved by: https://github.com/Skylion007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk fb-exported Merged release notes: python_frontend topic: fuzzer