Skip to content

Conversation

shuqiangzhang
Copy link
Contributor

@shuqiangzhang shuqiangzhang commented Oct 31, 2024

Stack from ghstack (oldest at bottom):

Summary:
Found those unused members when prototying something else.
Better remove unused members
Test Plan:
CI

Tags:

cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o

Summary:
Found those unused members when prototying something else.
Better remove unused members
Test Plan:
CI

Tags:

[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category labels Oct 31, 2024
Copy link

pytorch-bot bot commented Oct 31, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139436

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7fb730e with merge base 73fde0d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

shuqiangzhang added a commit that referenced this pull request Oct 31, 2024
Summary:
Found those unused members when prototying something else.
Better remove unused members
Test Plan:
CI

Tags:

ghstack-source-id: 4b282ea
Pull Request resolved: #139436
@cyyever
Copy link
Collaborator

cyyever commented Nov 1, 2024

@Skylion007 Do you know why deleting code would increase instruction counts?

@shuqiangzhang
Copy link
Contributor Author

@pytorchbot merge -f 'no CI failure after retry'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

rahulsingh-intel pushed a commit to rahulsingh-intel/pytorch that referenced this pull request Nov 5, 2024
Summary:
Found those unused members when prototying something else.
Better remove unused members
Test Plan:
CI

Tags:

Pull Request resolved: pytorch#139436
Approved by: https://github.com/Skylion007
@github-actions github-actions bot deleted the gh/shuqiangzhang/58/head branch December 2, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants