Move Storage and StorageImpl to c10 #14061
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D13081608 Differential Version: 63766089
This was referenced Nov 16, 2018
Differential Revision: D13081608 Differential Version: 63870849
This was referenced Nov 17, 2018
ezyang
reviewed
Nov 19, 2018
| double z[2]; | ||
| } v; | ||
| friend struct Type; | ||
| friend struct at::Type; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Nov 19, 2018
| @@ -0,0 +1,5 @@ | |||
| #include <c10/core/Storage.h> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Nov 19, 2018
| #include <c10/util/intrusive_ptr.h> | ||
|
|
||
| namespace at { | ||
| struct Type; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
approved these changes
Nov 19, 2018
Differential Revision: D13081608 Differential Version: 64074408
Differential Revision: D13081608 Differential Version: 64327189
Differential Revision: D13081608 Differential Version: 64563284
Differential Revision: D13081608 Differential Version: 64577701
Differential Revision: D13081608 Differential Version: 64581584
Differential Revision: D13081608 Differential Version: 64631492
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 27, 2018
Summary: Pull Request resolved: pytorch/pytorch#14061 Reviewed By: ezyang Differential Revision: D13081608 fbshipit-source-id: 1ea2d32e9ec9293b6ffa4b9e76c674cca55d5a1c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #14022 Move Scalar and ScalarType to c10/core 💚
:white_circle: #14023 Fix include paths for Scalar.h and ScalarType.h 💚
:white_circle: #14024 Move ScalarTypeUtils.h to c10 💚
:white_circle: #14058 Move UniqueVoidPtr to c10 💚
:white_circle: #14059 Move Allocator.h to c10 💚
:white_circle: #14060 Fix include paths for Allocator.h 💚
:black_circle: #14061 Move Storage and StorageImpl to c10 💚
:white_circle: #14062 Fix include paths for Storage.h and StorageImpl.h 💚
:white_circle: #14327 Move TensorTypeId to c10/core 💚
:white_circle: #14070 Fix include paths for TensorTypeId.h and TensorTypeIdRegistration.h 💚
:white_circle: #14141 Remove fake dependencies from TensorImpl to caffe2 💚
Differential Revision: D13081608