Remove StorageImpl::type() #14139
Closed
Remove StorageImpl::type() #14139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D12912238 Differential Version: 62761599
Differential Revision: D12912240 Differential Version: 62872842
Differential Revision: D12912237 Differential Version: 62872890
Differential Revision: D12912235 Differential Version: 62872887
Differential Revision: D12937090 Differential Version: 62872889
Differential Revision: D12937091 Differential Version: 62872885
Differential Revision: D12912238 Differential Version: 63021776
Differential Revision: D12912240 Differential Version: 63021779
Differential Revision: D12912237 Differential Version: 63021778
Differential Revision: D12912235 Differential Version: 63021785
Differential Revision: D12937090 Differential Version: 63021781
Differential Revision: D12937091 Differential Version: 63021777
Differential Revision: D12912238 Differential Version: 63035066
Differential Revision: D12912240 Differential Version: 63035067
Differential Revision: D12912237 Differential Version: 63035070
Differential Revision: D12912235 Differential Version: 63035072
Differential Revision: D12937090 Differential Version: 63035068
Differential Revision: D12937091 Differential Version: 63035071
Differential Revision: D12912240 Differential Version: 63063263
Differential Revision: D12912237 Differential Version: 63063267
Differential Revision: D12912235 Differential Version: 63063264
Differential Revision: D12937090 Differential Version: 63063262
Differential Revision: D12937091 Differential Version: 63063260
Differential Revision: D12937090 Differential Version: 63363262
Differential Revision: D12937091 Differential Version: 63363264
Differential Revision: D13015239 Differential Version: 63363260
Differential Revision: D13015236 Differential Version: 63363266
Differential Revision: D13081609 Differential Version: 63680085
Differential Revision: D13081604 Differential Version: 63680077
Differential Revision: D12937090 Differential Version: 63680384
This was referenced Nov 17, 2018
Differential Revision: D13111712 Differential Version: 64034093
ezyang
approved these changes
Nov 19, 2018
Differential Revision: D12937090 Differential Version: 64059750
Differential Revision: D12937091 Differential Version: 64059753
Differential Revision: D12937090 Differential Version: 64074417
Differential Revision: D12937091 Differential Version: 64074399
Differential Revision: D13015239 Differential Version: 64074405
Differential Revision: D13015236 Differential Version: 64074406
Differential Revision: D13081609 Differential Version: 64074409
Differential Revision: D13081604 Differential Version: 64074403
Differential Revision: D13081602 Differential Version: 64074398
Differential Revision: D13081606 Differential Version: 64074401
Differential Revision: D13081605 Differential Version: 64074402
Differential Revision: D13081608 Differential Version: 64074408
Differential Revision: D13081603 Differential Version: 64074407
Differential Revision: D13112298 Differential Version: 64074396
Differential Revision: D13112298 Differential Version: 64648232
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #14139 Remove StorageImpl::type() 💚
This seems neither be used nor implemented. Also, it is a c10->aten dependency which we don't want.
Differential Revision: D13112298