Skip to content

Conversation

seemethere
Copy link
Member

@seemethere seemethere commented Nov 22, 2024

Stack from ghstack (oldest at bottom):

Usage:

python3 tools/packaging/split_wheel.py bdist_wheel
python3 tools/packaging/split_wheel.py install
python3 tools/packaging/split_wheel.py develop

Ideally this should make it easier to do the split build locally while
we're doing development.

Signed-off-by: Eli Uriegas eliuriegas@meta.com

Usage:

> python3 tools/build/wheel/split_wheel.py bdist_wheel
> python3 tools/build/wheel/split_wheel.py install
> python3 tools/build/wheel/split_wheel.py develop

Ideally this should make it easier to do the split build locally while
we're doing development.

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>

[ghstack-poisoned]
@seemethere seemethere requested a review from a team as a code owner November 22, 2024 18:43
Copy link

pytorch-bot bot commented Nov 22, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141359

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 94bd919 with merge base e6962f8 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

  • linux-binary-manywheel / manywheel-py3_9-cuda11_8-test / test (gh) (trunk failure)
    ERROR: Could not find a version that satisfies the requirement pytorch-triton==3.2.0+35c6c7c628; platform_system == "Linux" and platform_machine == "x86_64" and python_version < "3.13" (from torch) (from versions: 2.0.0+0d7e753227, 2.0.0+3aa3d7024e, 2.0.0+af76c989eb, 2.0.0+b8b470bc59, 2.0.0+c8bfe3f548, 2.0.0+d54c04abe2, 2.1.0, 2.1.0+2c32f43999, 2.1.0+3c400e7818, 2.1.0+440fd1bf20, 2.1.0+46672772b4, 2.1.0+6e4932cda8, 2.1.0+7d1a95b046, 2.1.0+9820899b38, 2.1.0+9e3e10c5ed, 2.1.0+bcad9dabe1, 2.1.0+e6216047b8, 2.1.0+e650d3708b, 2.2.0+e28a256d71, 3.0.0+45fff310c8, 3.0.0+757b6a61e7, 3.0.0+901819d2b6, 3.0.0+989adb9a29, 3.0.0+a9bc1a3647, 3.0.0+dedb7bdf33, 3.1.0+5fe38ffd73, 3.1.0+cf34004b8a, 3.2.0+git35c6c7c6)
  • linux-binary-manywheel / manywheel-py3_9-cuda12_4-test / test (gh) (trunk failure)
    ERROR: Could not find a version that satisfies the requirement pytorch-triton==3.2.0+35c6c7c628; platform_system == "Linux" and platform_machine == "x86_64" and python_version < "3.13" (from torch) (from versions: 2.0.0+0d7e753227, 2.0.0+3aa3d7024e, 2.0.0+af76c989eb, 2.0.0+b8b470bc59, 2.0.0+c8bfe3f548, 2.0.0+d54c04abe2, 2.1.0, 2.1.0+2c32f43999, 2.1.0+3c400e7818, 2.1.0+440fd1bf20, 2.1.0+46672772b4, 2.1.0+6e4932cda8, 2.1.0+7d1a95b046, 2.1.0+9820899b38, 2.1.0+9e3e10c5ed, 2.1.0+bcad9dabe1, 2.1.0+e6216047b8, 2.1.0+e650d3708b, 2.2.0+e28a256d71, 3.0.0+45fff310c8, 3.0.0+757b6a61e7, 3.0.0+901819d2b6, 3.0.0+989adb9a29, 3.0.0+a9bc1a3647, 3.0.0+dedb7bdf33, 3.1.0+5fe38ffd73, 3.1.0+cf34004b8a, 3.2.0+git35c6c7c6)
  • linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test (gh) (trunk failure)
    ERROR: Could not find a version that satisfies the requirement pytorch-triton==3.2.0+35c6c7c628; platform_system == "Linux" and platform_machine == "x86_64" and python_version < "3.13" (from torch) (from versions: 2.0.0+0d7e753227, 2.0.0+3aa3d7024e, 2.0.0+af76c989eb, 2.0.0+b8b470bc59, 2.0.0+c8bfe3f548, 2.0.0+d54c04abe2, 2.1.0, 2.1.0+2c32f43999, 2.1.0+3c400e7818, 2.1.0+440fd1bf20, 2.1.0+46672772b4, 2.1.0+6e4932cda8, 2.1.0+7d1a95b046, 2.1.0+9820899b38, 2.1.0+9e3e10c5ed, 2.1.0+bcad9dabe1, 2.1.0+e6216047b8, 2.1.0+e650d3708b, 2.2.0+e28a256d71, 3.0.0+45fff310c8, 3.0.0+757b6a61e7, 3.0.0+901819d2b6, 3.0.0+989adb9a29, 3.0.0+a9bc1a3647, 3.0.0+dedb7bdf33, 3.1.0+5fe38ffd73, 3.1.0+cf34004b8a, 3.2.0+git35c6c7c6)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

seemethere added a commit that referenced this pull request Nov 22, 2024
Usage:

> python3 tools/build/wheel/split_wheel.py bdist_wheel
> python3 tools/build/wheel/split_wheel.py install
> python3 tools/build/wheel/split_wheel.py develop

Ideally this should make it easier to do the split build locally while
we're doing development.

Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

ghstack-source-id: 3615b07
Pull Request resolved: #141359
Usage:
```bash
python3 tools/build/wheel/split_wheel.py bdist_wheel
python3 tools/build/wheel/split_wheel.py install
python3 tools/build/wheel/split_wheel.py develop
```
Ideally this should make it easier to do the split build locally while
we're doing development.

Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

[ghstack-poisoned]
seemethere added a commit that referenced this pull request Nov 22, 2024
Usage:

> python3 tools/build/wheel/split_wheel.py bdist_wheel
> python3 tools/build/wheel/split_wheel.py install
> python3 tools/build/wheel/split_wheel.py develop

Ideally this should make it easier to do the split build locally while
we're doing development.

Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

ghstack-source-id: 0557545
Pull Request resolved: #141359

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
@seemethere
Copy link
Member Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 22, 2024
Usage:
```bash
python3 tools/build/wheel/split_wheel.py bdist_wheel
python3 tools/build/wheel/split_wheel.py install
python3 tools/build/wheel/split_wheel.py develop
```
Ideally this should make it easier to do the split build locally while
we're doing development.

Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

[ghstack-poisoned]
seemethere added a commit that referenced this pull request Nov 22, 2024
Usage:

> python3 tools/build/wheel/split_wheel.py bdist_wheel
> python3 tools/build/wheel/split_wheel.py install
> python3 tools/build/wheel/split_wheel.py develop

Ideally this should make it easier to do the split build locally while
we're doing development.

Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

ghstack-source-id: 82a9e42
Pull Request resolved: #141359

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like bdist_wheel(), install and develop are almost exact copies of each other and would benefit from helper run_split_build_cmd function

Comment on lines 49 to 54
subprocess.run(
cmd,
# Give the parent environment to the subprocess
env={**os.environ, **extra_env},
check=True,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
subprocess.run(
cmd,
# Give the parent environment to the subprocess
env={**os.environ, **extra_env},
check=True,
)
subprocess.check_call(
cmd,
# Give the parent environment to the subprocess
env={**os.environ, **extra_env},
)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subprocess.run(check=true) is actually the supported version of this now.

From: https://github.com/python/cpython/blob/75ef92da291247fd9d21ec26bd22bf8055b5f330/Lib/subprocess.py#L16-L40

Usage:
```bash
python3 tools/build/wheel/split_wheel.py bdist_wheel
python3 tools/build/wheel/split_wheel.py install
python3 tools/build/wheel/split_wheel.py develop
```
Ideally this should make it easier to do the split build locally while
we're doing development.

Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

[ghstack-poisoned]
seemethere added a commit that referenced this pull request Nov 22, 2024
Usage:

> python3 tools/build/wheel/split_wheel.py bdist_wheel
> python3 tools/build/wheel/split_wheel.py install
> python3 tools/build/wheel/split_wheel.py develop

Ideally this should make it easier to do the split build locally while
we're doing development.

Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

ghstack-source-id: 3e39b04
Pull Request resolved: #141359

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
Usage:
```bash
python3 tools/build/wheel/split_wheel.py bdist_wheel
python3 tools/build/wheel/split_wheel.py install
python3 tools/build/wheel/split_wheel.py develop
```
Ideally this should make it easier to do the split build locally while
we're doing development.

Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

[ghstack-poisoned]
seemethere added a commit that referenced this pull request Nov 22, 2024
Usage:

> python3 tools/build/wheel/split_wheel.py bdist_wheel
> python3 tools/build/wheel/split_wheel.py install
> python3 tools/build/wheel/split_wheel.py develop

Ideally this should make it easier to do the split build locally while
we're doing development.

Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

ghstack-source-id: c86b529
Pull Request resolved: #141359

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
Usage:
```bash
python3 tools/build/wheel/split_wheel.py bdist_wheel
python3 tools/build/wheel/split_wheel.py install
python3 tools/build/wheel/split_wheel.py develop
```
Ideally this should make it easier to do the split build locally while
we're doing development.

Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

[ghstack-poisoned]
seemethere added a commit that referenced this pull request Nov 23, 2024
Usage:

> python3 tools/packaging/split_wheel.py bdist_wheel
> python3 tools/packaging/split_wheel.py install
> python3 tools/packaging/split_wheel.py develop

Ideally this should make it easier to do the split build locally while
we're doing development.

Signed-off-by: Eli Uriegas <eliuriegasmeta.com>

ghstack-source-id: 9639e86
Pull Request resolved: #141359

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
@seemethere
Copy link
Member Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 26, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
Usage:
```bash
python3 tools/packaging/split_wheel.py bdist_wheel
python3 tools/packaging/split_wheel.py install
python3 tools/packaging/split_wheel.py develop
```
Ideally this should make it easier to do the split build locally while
we're doing development.

Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
Pull Request resolved: pytorch#141359
Approved by: https://github.com/kit1980
@github-actions github-actions bot deleted the gh/seemethere/1/head branch December 27, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants