-
Notifications
You must be signed in to change notification settings - Fork 25.6k
tools: Add script to do split build in one command #141359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Usage: > python3 tools/build/wheel/split_wheel.py bdist_wheel > python3 tools/build/wheel/split_wheel.py install > python3 tools/build/wheel/split_wheel.py develop Ideally this should make it easier to do the split build locally while we're doing development. Signed-off-by: Eli Uriegas <eliuriegas@meta.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141359
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 94bd919 with merge base e6962f8 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Usage: > python3 tools/build/wheel/split_wheel.py bdist_wheel > python3 tools/build/wheel/split_wheel.py install > python3 tools/build/wheel/split_wheel.py develop Ideally this should make it easier to do the split build locally while we're doing development. Signed-off-by: Eli Uriegas <eliuriegasmeta.com> ghstack-source-id: 3615b07 Pull Request resolved: #141359
Usage: ```bash python3 tools/build/wheel/split_wheel.py bdist_wheel python3 tools/build/wheel/split_wheel.py install python3 tools/build/wheel/split_wheel.py develop ``` Ideally this should make it easier to do the split build locally while we're doing development. Signed-off-by: Eli Uriegas <eliuriegasmeta.com> [ghstack-poisoned]
Usage: > python3 tools/build/wheel/split_wheel.py bdist_wheel > python3 tools/build/wheel/split_wheel.py install > python3 tools/build/wheel/split_wheel.py develop Ideally this should make it easier to do the split build locally while we're doing development. Signed-off-by: Eli Uriegas <eliuriegasmeta.com> ghstack-source-id: 0557545 Pull Request resolved: #141359 Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
@pytorchbot label "topic: not user facing" |
Usage: ```bash python3 tools/build/wheel/split_wheel.py bdist_wheel python3 tools/build/wheel/split_wheel.py install python3 tools/build/wheel/split_wheel.py develop ``` Ideally this should make it easier to do the split build locally while we're doing development. Signed-off-by: Eli Uriegas <eliuriegasmeta.com> [ghstack-poisoned]
Usage: > python3 tools/build/wheel/split_wheel.py bdist_wheel > python3 tools/build/wheel/split_wheel.py install > python3 tools/build/wheel/split_wheel.py develop Ideally this should make it easier to do the split build locally while we're doing development. Signed-off-by: Eli Uriegas <eliuriegasmeta.com> ghstack-source-id: 82a9e42 Pull Request resolved: #141359 Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like bdist_wheel()
, install
and develop
are almost exact copies of each other and would benefit from helper run_split_build_cmd
function
tools/build/wheel/split_wheel.py
Outdated
subprocess.run( | ||
cmd, | ||
# Give the parent environment to the subprocess | ||
env={**os.environ, **extra_env}, | ||
check=True, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subprocess.run( | |
cmd, | |
# Give the parent environment to the subprocess | |
env={**os.environ, **extra_env}, | |
check=True, | |
) | |
subprocess.check_call( | |
cmd, | |
# Give the parent environment to the subprocess | |
env={**os.environ, **extra_env}, | |
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subprocess.run(check=true)
is actually the supported version of this now.
Usage: ```bash python3 tools/build/wheel/split_wheel.py bdist_wheel python3 tools/build/wheel/split_wheel.py install python3 tools/build/wheel/split_wheel.py develop ``` Ideally this should make it easier to do the split build locally while we're doing development. Signed-off-by: Eli Uriegas <eliuriegasmeta.com> [ghstack-poisoned]
Usage: > python3 tools/build/wheel/split_wheel.py bdist_wheel > python3 tools/build/wheel/split_wheel.py install > python3 tools/build/wheel/split_wheel.py develop Ideally this should make it easier to do the split build locally while we're doing development. Signed-off-by: Eli Uriegas <eliuriegasmeta.com> ghstack-source-id: 3e39b04 Pull Request resolved: #141359 Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
Usage: ```bash python3 tools/build/wheel/split_wheel.py bdist_wheel python3 tools/build/wheel/split_wheel.py install python3 tools/build/wheel/split_wheel.py develop ``` Ideally this should make it easier to do the split build locally while we're doing development. Signed-off-by: Eli Uriegas <eliuriegasmeta.com> [ghstack-poisoned]
Usage: > python3 tools/build/wheel/split_wheel.py bdist_wheel > python3 tools/build/wheel/split_wheel.py install > python3 tools/build/wheel/split_wheel.py develop Ideally this should make it easier to do the split build locally while we're doing development. Signed-off-by: Eli Uriegas <eliuriegasmeta.com> ghstack-source-id: c86b529 Pull Request resolved: #141359 Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
Usage: ```bash python3 tools/build/wheel/split_wheel.py bdist_wheel python3 tools/build/wheel/split_wheel.py install python3 tools/build/wheel/split_wheel.py develop ``` Ideally this should make it easier to do the split build locally while we're doing development. Signed-off-by: Eli Uriegas <eliuriegasmeta.com> [ghstack-poisoned]
Usage: > python3 tools/packaging/split_wheel.py bdist_wheel > python3 tools/packaging/split_wheel.py install > python3 tools/packaging/split_wheel.py develop Ideally this should make it easier to do the split build locally while we're doing development. Signed-off-by: Eli Uriegas <eliuriegasmeta.com> ghstack-source-id: 9639e86 Pull Request resolved: #141359 Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Usage: ```bash python3 tools/packaging/split_wheel.py bdist_wheel python3 tools/packaging/split_wheel.py install python3 tools/packaging/split_wheel.py develop ``` Ideally this should make it easier to do the split build locally while we're doing development. Signed-off-by: Eli Uriegas <eliuriegas@meta.com> Pull Request resolved: pytorch#141359 Approved by: https://github.com/kit1980
Stack from ghstack (oldest at bottom):
Usage:
Ideally this should make it easier to do the split build locally while
we're doing development.
Signed-off-by: Eli Uriegas eliuriegas@meta.com