Skip to content

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Dec 9, 2024

The bc command that I use to calculate the MAX_JOBS in #142164 isn't part of the Docker image https://github.com/pytorch/pytorch/actions/runs/12230618287/job/34113698986#step:14:321. I missed this error when landing #142164.

Copy link

pytorch-bot bot commented Dec 9, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142359

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 5b0392a with merge base a108b28 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 9, 2024
@huydhn huydhn requested a review from a team December 9, 2024 09:12
ezyang added a commit that referenced this pull request Dec 9, 2024
This would have made #142359 a
hard failure.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

ghstack-source-id: e6df7b2
Pull Request resolved: #142377
@huydhn
Copy link
Contributor Author

huydhn commented Dec 9, 2024

@pytorchbot merge -f 'Docker builds are green now'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Dec 9, 2024
This would have made #142359 a
hard failure.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: #142377
Approved by: https://github.com/huydhn, https://github.com/malfet
bluenote10 pushed a commit to bluenote10/pytorch that referenced this pull request Dec 14, 2024
bluenote10 pushed a commit to bluenote10/pytorch that referenced this pull request Dec 14, 2024
This would have made pytorch#142359 a
hard failure.

Signed-off-by: Edward Z. Yang <ezyang@meta.com>
Pull Request resolved: pytorch#142377
Approved by: https://github.com/huydhn, https://github.com/malfet
@huydhn huydhn deleted the add-missing-bc-dep branch December 19, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants