dynamo tracing perf: import_module: 59.92 -> 52.9 #143057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

aorenste wants to merge 10 commits into gh/aorenste/155/base from gh/aorenste/155/head

Contributor

aorenste commented Dec 11, 2024 •

edited

Loading

Stack from ghstack (oldest at bottom):

See #143056 for overall docs.

This PR: Using importlib.import_module() within the hot path of
symbolic_convert is slow. Memoize it.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames


          import_module: 59.92 -> 52.9

2d784d7

See #143056 for overall docs.

This PR: Using `importlib.import_module()` within the hot path of
symbolic_convert is slow. Memoize it.

[ghstack-poisoned]

pytorch-bot bot commented Dec 11, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143057

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e247581 with merge base 8e48365 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added ciflow/inductor module: dynamo labels

This was referenced Dec 11, 2024

dynamo tracing perf: import in build: 60.48 -> 59.92 #143056

Closed

dynamo tracing perf: cache on import_source: 52.9 -> 52.58 #143058

Closed

dynamo tracing perf: direct Guard: 52.58 -> 51.76 #143059

Closed

dynamo tracing perf: Guard slots: 51.76 -> 51.34 #143060

Closed

dynamo tracing perf: c++ VariableTrackerCache: 51.34 -> 50.36 #143061

Closed

dynamo tracing perf: kill import: 50.36 -> 49.12 #143062

Closed

dynamo tracing perf: c++ strip_function_call: 49.12 -> 47.77 #143063

Closed

dynamo tracing perf: slight improvement on __instancecheck__: 47.77 -> 47.62 #143064

Closed

dynamo tracing perf: no import on hot path: 47.62 -> 47.26 #143065

Closed

dynamo tracing perf: don't unnecessarily call getframeinfo on the hot path: 47.26 -> 37.66 #143066

Closed

dynamo tracing perf: don't call expensive _set_guard_export_info if it's a duplicate guard: 37.66 -> 34.86 #143067

Closed

dynamo tracing perf: bytecode_transform improvements: 34.86 -> 33.9 #143068

Closed

dynamo tracing perf: no re in arg_ref: 33.9 -> 33.7 #143069

Closed

dynamo tracing perf: cache cleaned_instructions: 33.7 -> 30.0 #143070

Closed


          Update on "import_module: 59.92 -> 52.9"

23bfb59

See #143056 for overall docs.

This PR: Using `importlib.import_module()` within the hot path of
symbolic_convert is slow. Memoize it.

[ghstack-poisoned]

aorenste changed the title ~~import_module: 59.92 -> 52.9~~ dynamo tracing perf: import_module: 59.92 -> 52.9

aorenste added the topic: not user facing label

aorenste requested review from anijain2305 and jansel

December 12, 2024 02:20

jansel requested changes

View reviewed changes

Contributor

jansel left a comment

Fix lint errors

aorenste added 3 commits

December 12, 2024 16:35


          Update on "dynamo tracing perf: import_module: 59.92 -> 52.9"

6aa8fb9

See #143056 for overall docs.

This PR: Using `importlib.import_module()` within the hot path of
symbolic_convert is slow. Memoize it.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]


          Update on "dynamo tracing perf: import_module: 59.92 -> 52.9"

29f0b16

See #143056 for overall docs.

This PR: Using `importlib.import_module()` within the hot path of
symbolic_convert is slow. Memoize it.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]


          Update on "dynamo tracing perf: import_module: 59.92 -> 52.9"

ac17129

See #143056 for overall docs.

This PR: Using `importlib.import_module()` within the hot path of
symbolic_convert is slow. Memoize it.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

jansel approved these changes

View reviewed changes


          Update on "dynamo tracing perf: import_module: 59.92 -> 52.9"

ed554ac

See #143056 for overall docs.

This PR: Using `importlib.import_module()` within the hot path of
symbolic_convert is slow. Memoize it.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

aorenste added a commit that referenced this pull request


          import_module: 59.92 -> 52.9

9e0cd62

See #143056 for overall docs.

This PR: Using `importlib.import_module()` within the hot path of
symbolic_convert is slow. Memoize it.

ghstack-source-id: a8e64d6
Pull Request resolved: #143057


          Update on "dynamo tracing perf: import_module: 59.92 -> 52.9"

568f803

See #143056 for overall docs.

This PR: Using `importlib.import_module()` within the hot path of
symbolic_convert is slow. Memoize it.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

aorenste added a commit that referenced this pull request


          import_module: 59.92 -> 52.9

58ca536

See #143056 for overall docs.

This PR: Using `importlib.import_module()` within the hot path of
symbolic_convert is slow. Memoize it.

ghstack-source-id: 47df66b
Pull Request resolved: #143057


          Update on "dynamo tracing perf: import_module: 59.92 -> 52.9"

f983f2f

See #143056 for overall docs.

This PR: Using `importlib.import_module()` within the hot path of
symbolic_convert is slow. Memoize it.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

aorenste added a commit that referenced this pull request


          import_module: 59.92 -> 52.9

80d412f

See #143056 for overall docs.

This PR: Using `importlib.import_module()` within the hot path of
symbolic_convert is slow. Memoize it.

ghstack-source-id: 22a5b2f
Pull Request resolved: #143057


          Update on "dynamo tracing perf: import_module: 59.92 -> 52.9"

8b4aa97

See #143056 for overall docs.

This PR: Using `importlib.import_module()` within the hot path of
symbolic_convert is slow. Memoize it.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

aorenste added a commit that referenced this pull request


          import_module: 59.92 -> 52.9

8cb4b6f

See #143056 for overall docs.

This PR: Using `importlib.import_module()` within the hot path of
symbolic_convert is slow. Memoize it.

ghstack-source-id: 53c02e8
Pull Request resolved: #143057


          Update on "dynamo tracing perf: import_module: 59.92 -> 52.9"

e247581

See #143056 for overall docs.

This PR: Using `importlib.import_module()` within the hot path of
symbolic_convert is slow. Memoize it.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

pytorchmergebot closed this in

f2b744b

pytorchmergebot added the Merged label

pytorchmergebot pushed a commit that referenced this pull request


          dynamo tracing perf: kill import: 50.36 -> 49.12 (#143062)

3ec04d3

See #143056 for overall docs.

This PR: Stop importing in the body of `BuiltinVariable.call_getattr()`

Pull Request resolved: #143062
Approved by: https://github.com/jansel
ghstack dependencies: #143057

pytorchmergebot pushed a commit that referenced this pull request


          dynamo tracing perf: c++ strip_function_call: 49.12 -> 47.77 (#143063)

9bf4b1c

See #143056 for overall docs.

This PR: Convert `strip_function_call()` into C++

Pull Request resolved: #143063
Approved by: https://github.com/jansel
ghstack dependencies: #143057, #143062

github-actions bot deleted the gh/aorenste/155/head branch

January 22, 2025 02:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor Merged module: dynamo topic: not user facing