dynamo tracing perf: direct Guard: 52.58 -> 51.76 #143059
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #143056 for overall docs. This PR: Remove explicit constant check from `VariableBuilder.install_guards()` the args calling convention. Also remove a lambda binding. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143059
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit efcc0ef with merge base 82ce888 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Dec 11, 2024
Closed
See #143056 for overall docs. This PR: Remove explicit constant check from `VariableBuilder.install_guards()` the args calling convention. Also remove a lambda binding. [ghstack-poisoned]
aorenste
changed the title
williamwen42
approved these changes
Dec 12, 2024
jansel
approved these changes
Dec 12, 2024
See #143056 for overall docs. This PR: Remove explicit constant check from `VariableBuilder.install_guards()` the args calling convention. Also remove a lambda binding. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
See #143056 for overall docs. This PR: Remove explicit constant check from `VariableBuilder.install_guards()` the args calling convention. Also remove a lambda binding. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
See #143056 for overall docs. This PR: Remove explicit constant check from `VariableBuilder.install_guards()` the args calling convention. Also remove a lambda binding. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 13, 2024
bluenote10
pushed a commit
to bluenote10/pytorch
that referenced
this pull request
Dec 14, 2024
See pytorch#143056 for overall docs. This PR: Remove explicit constant check from `VariableBuilder.install_guards()` the args calling convention. Also remove a lambda binding. Pull Request resolved: pytorch#143059 Approved by: https://github.com/williamwen42, https://github.com/jansel ghstack dependencies: pytorch#143066, pytorch#143056, pytorch#143058
bluenote10
pushed a commit
to bluenote10/pytorch
that referenced
this pull request
Dec 14, 2024
See pytorch#143056 for overall docs. This PR: Add slots to Guard Pull Request resolved: pytorch#143060 Approved by: https://github.com/jansel ghstack dependencies: pytorch#143066, pytorch#143056, pytorch#143058, pytorch#143059
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
See #143056 for overall docs.
This PR: Remove explicit constant check from
VariableBuilder.install_guards()the args calling convention. Also remove a lambda binding.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames