Skip to content

remove allow-untyped-defs from distributed/elastic/utils/data/cycling_iterator.py #144090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

remove allow-untyped-defs from distributed/elastic/utils/data/cycling_iterator.py #144090

wants to merge 6 commits into from

Conversation

bobrenjc93
Copy link
Contributor

@bobrenjc93 bobrenjc93 commented Jan 2, 2025 •
edited
Loading

@bobrenjc93
Update
14e7d62 
[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (torchelastic) labels Jan 2, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144090

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 3 Pending

As of commit cce1849 with merge base d88a8c4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jan 2, 2025
Closed
Closed
Closed
Closed
Closed
@bobrenjc93 bobrenjc93 added the topic: not user facing topic category label Jan 2, 2025
@bobrenjc93 bobrenjc93 marked this pull request as ready for review January 2, 2025 18:42
@bobrenjc93
Update
a60e46c 
[ghstack-poisoned]
aorenste
aorenste reviewed Jan 2, 2025
View reviewed changes
@bobrenjc93
Update
4c126fa 
[ghstack-poisoned]
@bobrenjc93
Update
3aa09ef 
[ghstack-poisoned]
@bobrenjc93 bobrenjc93 requested a review from aorenste January 2, 2025 19:35
aorenste
aorenste reviewed Jan 2, 2025
View reviewed changes
@bobrenjc93
Update
4111e5a 
[ghstack-poisoned]
@bobrenjc93 bobrenjc93 requested a review from aorenste January 2, 2025 20:51
@bobrenjc93
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 2, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@bobrenjc93
Update on "remove allow-untyped-defs from distributed/elastic/utils/d…
cce1849 
…ata/cycling_iterator.py"

cc H-Huang awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o

[ghstack-poisoned]
bobrenjc93 added a commit that referenced this pull request Jan 2, 2025
@bobrenjc93
remove allow-untyped-defs from distributed/elastic/utils/data/cycling…
7e37b5e 
…_iterator.py

ghstack-source-id: 38df662
Pull Request resolved: #144090
@bobrenjc93
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever
Copy link
Collaborator

cyyever commented Jan 3, 2025

@pytorchmergebot merge -f "Unrelated pending"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/bobrenjc93/210/head branch February 2, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aorenste aorenste aorenste approved these changes

@Skylion007 Skylion007 Awaiting requested review from Skylion007

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (torchelastic) topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bobrenjc93 @pytorchmergebot @cyyever @aorenste