Skip to content

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Feb 2, 2025

Fixes #ISSUE_NUMBER

cc @seemethere @malfet @pytorch/pytorch-dev-infra @albanD

Copy link

pytorch-bot bot commented Feb 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146268

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 56d776a with merge base d89c7ea (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Feb 2, 2025
@cyyever cyyever marked this pull request as draft February 2, 2025 04:11
@cyyever cyyever added module: macos Mac OS related issues module: ci Related to continuous integration and removed module: ci Related to continuous integration labels Feb 2, 2025
@cyyever cyyever marked this pull request as ready for review February 2, 2025 12:34
@Skylion007
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 2, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, skip test is evil, it should always be xfail

@cyyever
Copy link
Collaborator Author

cyyever commented Feb 3, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: macos Mac OS related issues open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants