Moved Backend to c10 #14642
Closed
Moved Backend to c10 #14642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D13283495 Differential Version: 65035202
This was referenced Nov 30, 2018
Closed
Differential Revision: D13283495 Differential Version: 65268356
ezyang
reviewed
Dec 4, 2018
|
|
||
| namespace at { | ||
|
|
||
| namespace c10 { |
There was a problem hiding this comment.
Is there any reason this can't live with the actual implementation?
There was a problem hiding this comment.
it's kind of common to keep it separate (boost does the same for optional I/O) because iostream is a huge header to pull in. Otherwise, there's no strong reason though and I don't have a strong opinion on it. It would definitely be more convenient to have it with the implementation.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Dec 4, 2018
Summary: Pull Request resolved: pytorch/pytorch#14642 Unfortunately, TensorOptions depends on this, so we need it in c10. Reviewed By: ezyang Differential Revision: D13283495 fbshipit-source-id: 433cd47eb18aac1131be9c5cd650efc583870a20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #14642 Moved Backend to c10 💛
:white_circle: #14643 Fix include paths for Backend.h 💛
:white_circle: #14644 Move Layout to c10 💛
:white_circle: #14645 Fix include paths for Layout.h 💛
:white_circle: #14646 Move TensorOptions, DefaultTensorOptions and OptionsGuard to c10 💛
:white_circle: #14647 Fix include paths for TensorOptions, DefaultTensorOptions, OptionsGuard 💛
:white_circle: #14651 Remove TensorImpl -> LegacyTypeDispatch dependency 💛
:white_circle: #14658 Remove TensorImpl -> context_base dependency 💛
Unfortunately, TensorOptions depends on this, so we need it in c10.
Differential Revision: D13283495