Skip to content

Conversation

smessmer
Copy link
Contributor

@smessmer smessmer commented Nov 30, 2018

Stack:
    :white_circle:  #14642 Moved Backend to c10  💛
    :white_circle:  #14643 Fix include paths for Backend.h  💛
    :white_circle:  #14644 Move Layout to c10  💛
    :white_circle:  #14645 Fix include paths for Layout.h  💛
    :white_circle:  #14646 Move TensorOptions, DefaultTensorOptions and OptionsGuard to c10  💛
    :black_circle:  #14647 Fix include paths for TensorOptions, DefaultTensorOptions, OptionsGuard  💛
    :white_circle:  #14651 Remove TensorImpl -> LegacyTypeDispatch dependency  💛
    :white_circle:  #14658 Remove TensorImpl -> context_base dependency  💛

Differential Revision: D13283497

Differential Revision: D13283497
Differential Version: 65035198
Differential Revision: D13283497
Differential Version: 65268358
@peterjc123
Copy link
Collaborator

peterjc123 commented Dec 4, 2018

This PR causes build failure on Windows.
Update: Sorry, #14646 should be the cause.

@peterjc123
Copy link
Collaborator

The error log on PyTorch Windows CI:

06:38:46 TensorOptions.cpp.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: struct c10::Device __cdecl c10::TensorOptions::device(void)const " (__imp_?device@TensorOptions@c10@@QEBA?AUDevice@2@XZ) referenced in function "class std::basic_ostream<char,struct std::char_traits<char> > & __cdecl c10::operator<<(class std::basic_ostream<char,struct std::char_traits<char> > &,struct c10::TensorOptions const &)" (??6c10@@YAAEAV?$basic_ostream@DU?$char_traits@D@std@@@std@@AEAV12@AEBUTensorOptions@0@@Z)
06:38:46 TensorOptions.cpp.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: class caffe2::TypeMeta __cdecl c10::TensorOptions::dtype(void)const " (__imp_?dtype@TensorOptions@c10@@QEBA?AVTypeMeta@caffe2@@XZ) referenced in function "class std::basic_ostream<char,struct std::char_traits<char> > & __cdecl c10::operator<<(class std::basic_ostream<char,struct std::char_traits<char> > &,struct c10::TensorOptions const &)" (??6c10@@YAAEAV?$basic_ostream@DU?$char_traits@D@std@@@std@@AEAV12@AEBUTensorOptions@0@@Z)
06:38:46 TensorOptions.cpp.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: enum c10::Layout __cdecl c10::TensorOptions::layout(void)const " (__imp_?layout@TensorOptions@c10@@QEBA?AW4Layout@2@XZ) referenced in function "class std::basic_ostream<char,struct std::char_traits<char> > & __cdecl c10::operator<<(class std::basic_ostream<char,struct std::char_traits<char> > &,struct c10::TensorOptions const &)" (??6c10@@YAAEAV?$basic_ostream@DU?$char_traits@D@std@@@std@@AEAV12@AEBUTensorOptions@0@@Z)
06:38:46 TensorOptions.cpp.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: bool __cdecl c10::TensorOptions::requires_grad(void)const " (__imp_?requires_grad@TensorOptions@c10@@QEBA_NXZ) referenced in function "class std::basic_ostream<char,struct std::char_traits<char> > & __cdecl c10::operator<<(class std::basic_ostream<char,struct std::char_traits<char> > &,struct c10::TensorOptions const &)" (??6c10@@YAAEAV?$basic_ostream@DU?$char_traits@D@std@@@std@@AEAV12@AEBUTensorOptions@0@@Z)

zdevito pushed a commit to zdevito/ATen that referenced this pull request Dec 4, 2018
Summary: Pull Request resolved: pytorch/pytorch#14647

Reviewed By: ezyang

Differential Revision: D13283497

fbshipit-source-id: d236d5351ecf7ab9712a55e9ef12d8bba48eb53f
@soumith soumith deleted the export-D13283497 branch February 21, 2019 23:28
@ezyang ezyang added the merged label Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants