try print stacktrace for error #147061
try print stacktrace for error #147061
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/147061
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 3 Pending, 3 Unrelated FailuresAs of commit 24bfc7b with merge base b0553ce ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D69573525 |
torch/_inductor/codegen/common.py
Outdated
| except NotImplementedError as e: | ||
| log.info( | ||
| "Cannot Append Choice: %s", | ||
| stack_info=True if log.getEffectiveLevel() < logging.INFO else False, |
There was a problem hiding this comment.
Is this necessary? Stack_info=True should have no effect if the level is not at least log.info level? You could also pass exc_info for a more detailed trace.
There was a problem hiding this comment.
Is this necessary? Stack_info=True should have no effect if the level is not at least log.info level? You could also pass exc_info for a more detailed trace.
I want to print the error with a higher logging level (info) and print also the stack trace at debug so to not spam people. Let me know what you think
There was a problem hiding this comment.
Ah I see it's, suppose to be printer at debug only. Makes sense then. Nit should probably just be a cast to bool instead of this if else
There was a problem hiding this comment.
landing with stack_info=log.getEffectiveLevel() < logging.INFO, for now. Let me know if you prefer a bool cast since it is a bit ugly right now
torch/_inductor/codegen/common.py
Outdated
| return None | ||
| except NotImplementedError as e: | ||
| log.info( | ||
| "Cannot Append Choice: %s", |
There was a problem hiding this comment.
The choice % string isn't populated into this string, shouldn't it be?
Summary: Pull Request resolved: pytorch#147061 Differential Revision: D69573525
henrylhtsang
force-pushed
the
export-D69573525
branch
from
a34a25d to
24bfc7b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69573525 |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 3 checks: inductor / unit-test / linux-jammy-cpu-py3.9-gcc11-inductor / test (inductor_amx, 2, 2, linux.8xlarge.amx), inductor / unit-test / linux-jammy-cpu-py3.9-gcc11-inductor / test (inductor_avx2, 2, 2, linux.10xlarge.avx2), trunk / win-vs2022-cuda12.1-py3 / build Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
4 participants
Differential Revision: D69573525
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov