Skip to content

[pytorch] Update flexattention bwd config generation #148600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[pytorch] Update flexattention bwd config generation #148600

wants to merge 1 commit into from

Conversation

mandroid6
Copy link

@mandroid6 mandroid6 commented Mar 5, 2025 •
edited by pytorch-bot bot
Loading

Summary: Currently flex_attention template's backward config generation returns values for every case. This change instead stores intermediate values in 'bwd_config returned at the end.

Test Plan: CI. Existing tests.

Differential Revision: D70649316

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 5, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mandroid6 / name: Mandar Deshpande (c42cd67)

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148600

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c42cd67 with merge base ebd087e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70649316

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70649316

mandroid6 pushed a commit to mandroid6/pytorch that referenced this pull request Mar 5, 2025
@facebook-github-bot
[pytorch] Update flexattention bwd config generation (pytorch#148600)
a863908 
Summary:
Pull Request resolved: pytorch#148600

Currently `flex_attention` template's backward config generation returns values for every case. This change instead stores intermediate values in `'bwd_config` returned at the end which simplifies inspection/debugging.

Test Plan: CI. Existing tests.

Differential Revision: D70649316
@drisspg drisspg added the topic: not user facing topic category label Mar 5, 2025
@mandroid6 mandroid6 self-assigned this Mar 6, 2025
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 8, 2025
@facebook-github-bot
[pytorch] Update flexattention bwd config generation (pytorch#148600)
c42cd67 
Summary:

Currently `flex_attention` template's backward config generation returns values for every case. This change instead stores intermediate values in `'bwd_config` returned at the end which simplifies inspection/debugging.

Test Plan: CI. Existing tests.

Reviewed By: drisspg

Differential Revision: D70649316
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70649316

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees

@mandroid6 mandroid6

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mandroid6 @facebook-github-bot @pytorchmergebot @Skylion007 @drisspg